From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753378AbbIRTJR (ORCPT ); Fri, 18 Sep 2015 15:09:17 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:38062 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751752AbbIRTJP (ORCPT ); Fri, 18 Sep 2015 15:09:15 -0400 Date: Fri, 18 Sep 2015 21:09:12 +0200 From: Luis de Bethencourt To: Alan Stern Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver Message-ID: <20150918190912.GA1293@goodgumbo.baconseed.org> References: <20150918182104.GA31589@goodgumbo.baconseed.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 02:57:10PM -0400, Alan Stern wrote: > On Fri, 18 Sep 2015, Luis de Bethencourt wrote: > > > This platform driver has a OF device ID table but the OF module > > alias information is not created so module autoloading won't work. > > > > Signed-off-by: Luis de Bethencourt > > --- > > drivers/usb/host/ehci-spear.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c > > index 34e1474..be7bcf2 100644 > > --- a/drivers/usb/host/ehci-spear.c > > +++ b/drivers/usb/host/ehci-spear.c > > @@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = { > > { .compatible = "st,spear600-ehci", }, > > { }, > > }; > > +MODULE_DEVICE_TABLE(spear_ehci_id_table); > > Shouldn't this be MODULE_DEVICE_TABLE(of, spear_ehci_id_table)? > > Alan Stern > Hi Alan, Sorry about this. It looks like I accidentally sent a temporary version of patch 1/4 and 3/4. Sending the final and correct version now. Thanks for the review, Luis