From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754747AbbIRWmA (ORCPT ); Fri, 18 Sep 2015 18:42:00 -0400 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:38859 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754643AbbIRWl7 (ORCPT ); Fri, 18 Sep 2015 18:41:59 -0400 From: "Sinclair Yeh" Date: Fri, 18 Sep 2015 15:42:50 -0700 To: Christian Engelmayer Cc: airlied@linux.ie, thellstrom@vmware.com, daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty() Message-ID: <20150918224234.GB18173@syeh-linux> References: <1442615544-22203-1-git-send-email-cengelma@gmx.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442615544-22203-1-git-send-email-cengelma@gmx.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Sinclair Yeh On Sat, Sep 19, 2015 at 12:32:24AM +0200, Christian Engelmayer wrote: > Function vmw_kms_helper_dirty() uses the uninitialized variable ret as > return value. Make the result deterministic and directly return as the > variable is unused anyway. Detected by Coverity CID 1324255. > > Signed-off-by: Christian Engelmayer > --- > Compile tested only. Applies against linux-next. > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > index 61fb7f3de311..15a6c01cd016 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > @@ -1685,7 +1685,6 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv, > struct drm_crtc *crtc; > u32 num_units = 0; > u32 i, k; > - int ret; > > dirty->dev_priv = dev_priv; > > @@ -1711,7 +1710,7 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv, > if (!dirty->cmd) { > DRM_ERROR("Couldn't reserve fifo space " > "for dirty blits.\n"); > - return ret; > + return -ENOMEM; > } > memset(dirty->cmd, 0, dirty->fifo_reserve_size); > } > -- > 1.9.1 >