From: Mark Brown <broonie@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>,
Jason Coughlan <jason.coughlan@diasemi.com>
Subject: Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio codec
Date: Sat, 19 Sep 2015 10:10:17 -0700 [thread overview]
Message-ID: <20150919171017.GI30445@sirena.org.uk> (raw)
In-Reply-To: <381b367e0a4c6c9e00db74f1b0e91d383156ba86.1442500784.git.Adam.Thomson.Opensource@diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
On Thu, Sep 17, 2015 at 05:01:16PM +0100, Adam Thomson wrote:
> +- dlg,io-lvl : Expected voltage level range for digital IO
> + ["2.5V_3.6V", "1.2V_2.8V"]
If the driver needs to read or set the voltage a supply is at it should
do that via the regulator API.
> +- dlg,cp-mchange : Charge pump voltage tracking mode
> + ["largest_vol", "dac_vol", "sig_mag"]
> +- dlg,cp-vol-thresh : Charge pump volume threshold value (6-bit value)
> + [ 0 - 0x3F ]
Why are these in the device tree rather than runtime parameters?
> +Child node - 'da7219_aad':
> +
> +Required properties:
> +- interrupt-parent : Specifies the phandle of the interrupt controller to which
> + the IRQs from DA7219 AAD block are delivered to.
> +- interrupts : IRQ line info for DA7219 AAD block.
> + (See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt for
> + further information relating to interrupt properties)
Why is this not specified at the device level (the device does not
appear to support other interrupts)?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-20 0:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 16:01 [PATCH 0/3] ASoC: Add support " Adam Thomson
2015-09-17 16:01 ` [PATCH 1/3] ASoC: codecs: Add da7219 codec driver Adam Thomson
2015-09-19 17:44 ` Mark Brown
2015-09-21 15:08 ` Opensource [Adam Thomson]
2015-09-21 17:11 ` Mark Brown
2015-09-22 13:00 ` Opensource [Adam Thomson]
2015-09-17 16:01 ` [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio codec Adam Thomson
2015-09-19 17:10 ` Mark Brown [this message]
2015-09-21 10:36 ` Opensource [Adam Thomson]
2015-09-21 16:40 ` Mark Brown
2015-09-17 16:01 ` [PATCH 3/3] MAINTAINERS: da7219: Add entry to cover DA7219 bindings document Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150919171017.GI30445@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason.coughlan@diasemi.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®