From: Mark Brown <broonie@kernel.org>
To: Jean-Michel Hautbois <jean-michel.hautbois@veo-labs.com>
Cc: linux-spi@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: spi-imx: wait_for_completion should timeout even in non-DMA transfer cases
Date: Sat, 19 Sep 2015 10:56:14 -0700 [thread overview]
Message-ID: <20150919175614.GM30445@sirena.org.uk> (raw)
In-Reply-To: <CAH-u=81E2RnMvm2UZxUasCSf6hMQtiMO9Y1VcNiy0pFR6Uy6vg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
On Fri, Sep 18, 2015 at 02:38:27PM +0200, Jean-Michel Hautbois wrote:
> Hi,
>
> I am wondering why in spi-imx the spi_imx_pio_transfer() function is
> calling wait_for_completion() and not wait_for_completion_timeout() as
> in the spi_imx_dma_transfer() one.
> I can't see a good reason for this, maybe should it be calculated
> based on the spi clock and transfer->len, or at least be the same as
> IMX_DMA_TIMEOUT which is 3 seconds ?
> If you want it, I have a patch, just tell me if you are interested and
> if you prefer a calculated timeout or even something else ?
A calculated timeout is probably best.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-20 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 12:38 Jean-Michel Hautbois
2015-09-19 17:56 ` Mark Brown [this message]
2015-09-21 9:08 ` Jean-Michel Hautbois
2015-09-22 17:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150919175614.GM30445@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jean-michel.hautbois@veo-labs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®