From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap
Date: Sat, 19 Sep 2015 11:40:21 -0700 [thread overview]
Message-ID: <20150919184021.GQ30445@sirena.org.uk> (raw)
In-Reply-To: <1442339861-30300-3-git-send-email-afd@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
On Tue, Sep 15, 2015 at 12:57:40PM -0500, Andrew F. Davis wrote:
> The old driver does not support DT. Rewrite the driver adding DT support
> and use modern kernel features such as regmap and related helpers.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> drivers/gpio/gpio-tps65912.c | 291 ++++++------
> drivers/mfd/Kconfig | 20 +-
> drivers/mfd/Makefile | 3 +-
> drivers/mfd/tps65912-core.c | 288 +++++-------
> drivers/mfd/tps65912-i2c.c | 233 ++++------
> drivers/mfd/tps65912-irq.c | 217 ---------
> drivers/mfd/tps65912-spi.c | 236 ++++------
> drivers/regulator/tps65912-regulator.c | 783 ++++++++++-----------------------
> include/linux/mfd/tps65912.h | 256 +++++++----
> 9 files changed, 854 insertions(+), 1473 deletions(-)
It's not OK to have a single commit that rewrites multiple drivers over
many subsystems, that's really not something that can be sensibly
reviewed. You should split this into a patch series which makes one
specific change at a time as covered in SubmittingPatches. That will
allow the changes to be reviewed much more sensibly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-20 0:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 17:57 [PATCH 0/3] mfd: tps65912: Driver rewrite with DT support Andrew F. Davis
2015-09-15 17:57 ` [PATCH 1/3] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC Andrew F. Davis
2015-09-20 4:16 ` Lee Jones
2015-09-21 16:32 ` Andrew F. Davis
2015-09-21 23:07 ` Lee Jones
2015-09-22 19:58 ` Andrew F. Davis
2015-09-15 17:57 ` [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap Andrew F. Davis
2015-09-19 18:40 ` Mark Brown [this message]
2015-09-21 16:42 ` Andrew F. Davis
2015-09-21 19:26 ` Mark Brown
2015-09-21 19:46 ` Andrew F. Davis
2015-09-21 19:54 ` Mark Brown
2015-09-21 19:59 ` Andrew F. Davis
2015-09-20 4:16 ` Lee Jones
2015-09-21 18:22 ` Andrew F. Davis
2015-09-21 23:04 ` Lee Jones
2015-09-15 17:57 ` [PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration dependencies Andrew F. Davis
2015-09-16 19:57 ` Mark Brown
2015-10-02 10:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150919184021.GQ30445@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®