From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756093AbbIUFzY (ORCPT ); Mon, 21 Sep 2015 01:55:24 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:48902 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755844AbbIUFzX (ORCPT ); Mon, 21 Sep 2015 01:55:23 -0400 Date: Sun, 20 Sep 2015 22:55:21 -0700 (PDT) Message-Id: <20150920.225521.1063980101511317898.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: tj@kernel.org, cwang@twopensource.com, tom@herbertland.com, kafai@fb.com, kernel-team@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, torvalds@linux-foundation.org, jiri@resnulli.us, nicolas.dichtel@6wind.com, tgraf@suug.ch, sfeldma@gmail.com Subject: Re: [PATCH v4] netlink: Fix autobind race condition that leads to zero port ID From: David Miller In-Reply-To: <20150918111650.GA7508@gondor.apana.org.au> References: <20150917113034.GA14471@htj.duckdns.org> <20150918063609.GA31747@gondor.apana.org.au> <20150918111650.GA7508@gondor.apana.org.au> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 20 Sep 2015 22:55:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herbert Xu Date: Fri, 18 Sep 2015 19:16:50 +0800 > The commit c0bb07df7d981e4091432754e30c9c720e2c0c78 ("netlink: > Reset portid after netlink_insert failure") introduced a race > condition where if two threads try to autobind the same socket > one of them may end up with a zero port ID. This led to kernel > deadlocks that were observed by multiple people. > > This patch reverts that commit and instead fixes it by introducing > a separte rhash_portid variable so that the real portid is only set > after the socket has been successfully hashed. > > Fixes: c0bb07df7d98 ("netlink: Reset portid after netlink_insert failure") > Reported-by: Tejun Heo > Reported-by: Linus Torvalds > Signed-off-by: Herbert Xu Applied and queued up for -stable, thanks Herbert.