From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754824AbbITJdj (ORCPT ); Sun, 20 Sep 2015 05:33:39 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:34878 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753823AbbITJdg (ORCPT ); Sun, 20 Sep 2015 05:33:36 -0400 Date: Sun, 20 Sep 2015 11:33:33 +0200 From: Michal Hocko To: Linus Torvalds Cc: Oleg Nesterov , Kyle Walker , Christoph Lameter , Andrew Morton , David Rientjes , Johannes Weiner , Vladimir Davydov , linux-mm , Linux Kernel Mailing List , Stanislav Kozina , Tetsuo Handa Subject: Re: can't oom-kill zap the victim's memory? Message-ID: <20150920093332.GA20562@dhcp22.suse.cz> References: <1442512783-14719-1-git-send-email-kwalker@redhat.com> <20150919150316.GB31952@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 19-09-15 15:24:02, Linus Torvalds wrote: > On Sat, Sep 19, 2015 at 8:03 AM, Oleg Nesterov wrote: > > + > > +static void oom_unmap_func(struct work_struct *work) > > +{ > > + struct mm_struct *mm = xchg(&oom_unmap_mm, NULL); > > + > > + if (!atomic_inc_not_zero(&mm->mm_users)) > > + return; > > + > > + // If this is not safe we can do use_mm() + unuse_mm() > > + down_read(&mm->mmap_sem); > > I don't think this is safe. > > What makes you sure that we might not deadlock on the mmap_sem here? > For all we know, the process that is going out of memory is in the > middle of a mmap(), and already holds the mmap_sem for writing. No? > > So at the very least that needs to be a trylock, I think. Agreed. > And I'm not > sure zap_page_range() is ok with the mmap_sem only held for reading. > Normally our rule is that you can *populate* the page tables > concurrently, but you can't tear the down Actually mmap_sem for reading should be sufficient because we do not alter the layout. Both MADV_DONTNEED and MADV_FREE require read mmap_sem for example. -- Michal Hocko SUSE Labs