From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754902AbbITRYg (ORCPT ); Sun, 20 Sep 2015 13:24:36 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42775 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753198AbbITRYe (ORCPT ); Sun, 20 Sep 2015 13:24:34 -0400 X-Sasl-enc: pYc+9ymIYB1ikk++5KoSQa+V/Q8hDFMmh89MRKM1JblO 1442769873 Date: Sun, 20 Sep 2015 10:24:31 -0700 From: Greg KH To: Knuth Posern Cc: linux-kernel@vger.kernel.org, Andreas Noever , linux-pci@vger.kernel.org Subject: Re: [PATCH] Thunderbolt 2 driver for recent Apple MacBooks Message-ID: <20150920172431.GB27148@kroah.com> References: <55FEDAAD.6000804@posern.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55FEDAAD.6000804@posern.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 20, 2015 at 06:11:25PM +0200, Knuth Posern wrote: > Hi, > > This patch is submitted for upstream inclusion. > This is a first for me, so I hope the format of this mail is convenient. > > Thanks to Greg and Andreas the attached patch (diff -up) fixes the bug: > https://bugzilla.kernel.org/show_bug.cgi?id=100191 > > The pci device ids listed in the tb driver are to restrictive, which > prevents the driver from being loaded. We have had a similar issue > with the new Mac mini. > > Changing the subvendor and subdevice to PCI_ANY_ID in > drivers/thunderbolt/nhi.c > the thunderbolt driver loads and binds to the pci device > 07:00.0 System peripheral: Intel Corporation Device 156c > which is the thunderbolt 2 controller. > > > Cheers, > > Knuth. > > --- linux/drivers/thunderbolt/nhi.c.orig 2015-09-20 17:36:14.014964300 +0200 > +++ linux/drivers/thunderbolt/nhi.c 2015-09-13 09:58:18.000000000 +0200 > @@ -643,7 +643,7 @@ static struct pci_device_id nhi_ids[] = > { > .class = PCI_CLASS_SYSTEM_OTHER << 8, .class_mask = ~0, > .vendor = PCI_VENDOR_ID_INTEL, .device = 0x156c, > - .subvendor = 0x2222, .subdevice = 0x1111, > + .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID, > }, > { 0,} > }; > > This looks good, but can you resend it in the format described in Documentation/SubmittingPatches so that I can apply it (i.e. a cleaned up changelog comment and a signed-off-by: line?) thanks, greg k-h