From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755901AbbIUE6f (ORCPT ); Mon, 21 Sep 2015 00:58:35 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33738 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752128AbbIUE6d (ORCPT ); Mon, 21 Sep 2015 00:58:33 -0400 Date: Mon, 21 Sep 2015 10:28:27 +0530 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] tty/vt: don't set font mappings on vc not supporting this Message-ID: <20150921045825.GB6962@sudip-pc> References: <20150912155506.GE29944@kroah.com> <1442124231-13016-1-git-send-email-sudipm.mukherjee@gmail.com> <20150921014015.GA15631@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150921014015.GA15631@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 20, 2015 at 06:40:15PM -0700, Greg Kroah-Hartman wrote: > On Sun, Sep 13, 2015 at 11:33:51AM +0530, Sudip Mukherjee wrote: > > commit 9e326f78713a4421fe11afc2ddeac07698fac131 upstream > > Cc: # 3.14.x > > Signed-off-by: Sudip Mukherjee > > --- > > > > backporting for the first time so not exactly sure if the format is ok. > > You need to keep the original authorship of the patch around, as well as > their signed-off-by information. Also, you didn't backport it > identically: > > > + > > + if (!p) { > > + err = -EINVAL; > > + goto out_unlock; > > The original has a blank line between these two lines, why not keep it? > > I'll fix it up, but be a bit more careful next time please. Sure, next time you will have no complaints about this. regards sudip