From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756081AbbIUFoF (ORCPT ); Mon, 21 Sep 2015 01:44:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35687 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756028AbbIUFoD (ORCPT ); Mon, 21 Sep 2015 01:44:03 -0400 Date: Sun, 20 Sep 2015 22:44:01 -0700 From: Greg Kroah-Hartman To: Tomas Winkler Cc: Alexander Usyskin , linux-kernel@vger.kernel.org Subject: Re: [char-misc 4.3] mei: hbm: fix error in state check logic Message-ID: <20150921054401.GA27562@kroah.com> References: <1442129366-13061-1-git-send-email-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1442129366-13061-1-git-send-email-tomas.winkler@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2015 at 10:29:26AM +0300, Tomas Winkler wrote: > From: Alexander Usyskin > > Use || instead && in state check. > Latter is bogus and leads to following warning: > > drivers/misc/mei/hbm.c:1212:46: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op] > > Fixes: 073e6274 ("mei: support for dynamic clients") This isn't a commit id in Linus's tree anywhere, where did you get that number from? Please fix it and use a valid one. thanks, greg k-h