From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932799AbbIUOQL (ORCPT ); Mon, 21 Sep 2015 10:16:11 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:36688 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932426AbbIUOQH (ORCPT ); Mon, 21 Sep 2015 10:16:07 -0400 Date: Mon, 21 Sep 2015 15:15:41 +0100 From: Russell King - ARM Linux To: Thierry Reding Cc: Douglas Anderson , airlied@linux.ie, fabio.estevam@freescale.com, ykk@rock-chips.com, p.zabel@pengutronix.de, andy.yan@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] CHROMIUM: drm: bridge/dw_hdmi: Eliminate unused cable_plugin Message-ID: <20150921141541.GO21084@n2100.arm.linux.org.uk> References: <1442436098-26608-1-git-send-email-dianders@chromium.org> <20150921095104.GB20992@ulmo.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150921095104.GB20992@ulmo.nvidia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 11:51:06AM +0200, Thierry Reding wrote: > On Wed, Sep 16, 2015 at 01:41:38PM -0700, Douglas Anderson wrote: > > There's a member in 'struct dw_hdmi' called cable_plugin. It's never > > set to anything anywhere so thus is always false. There's a bit of code > > checking it, but since it's always false this must be dead code. > > Eliminate it. > > > > Note: if someone wants to figure out the intention of the original code > > and implement whatever feature / fix was needed then we can drop this > > patch. The 'cable_plugin' member has been unused since the code was > > first added in (9aaf880 imx-drm: Add mx6 hdmi transmitter support). > > > > Signed-off-by: Douglas Anderson > > --- > > drivers/gpu/drm/bridge/dw_hdmi.c | 9 --------- > > 1 file changed, 9 deletions(-) > > Except for the CHROMIUM: prefix this looks good to me: > > Reviewed-by: Thierry Reding > > Russell, do you have patches to this driver queued for v4.4 and plan to > pick this up into your tree or should I take it? My current patch stack for imx-drm related stuff looks like this at present: drm: bridge/dw_hdmi: place PHY into low power mode when disabled drm: bridge/dw_hdmi: start of support for pixel doubled modes drm: bridge/dw_hdmi: remove CEC engine register definitions drm: bridge/dw_hdmi-cec: add Designware HDMI CEC driver cec: add HDMI CEC input driver cec: add HDMI CEC core driver drm: bridge/dw_hdmi: replace CTS calculation for the ACR drm: bridge/dw_hdmi: remove ratio support from ACR code drm: bridge/dw_hdmi: adjust pixel clock values in N calculation drm: bridge/dw_hdmi: avoid being recursive in N calculation drm: bridge/dw_hdmi-ahb-audio: allow larger buffer sizes drm: bridge/dw_hdmi-ahb-audio: basic support for multi-channel PCM audio drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver drm: bridge/dw_hdmi-ahb-audio: add audio driver drm: bridge/dw_hdmi: improve HDMI enable/disable handling drm: bridge/dw_hdmi: add connector mode forcing drm: bridge/dw_hdmi: add support for interlaced video modes gpu: imx: fix support for interlaced modes gpu: imx: simplify sync polarity setting I haven't yet decided what, if anything, from that stack I'm going to try to get into the next merge window. Given the lack of interest last time I posted these patches, I'm loosing interest myself in trying to get them merged, especially ones which are getting on for being 2 years old. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.