From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932830AbbIUQlE (ORCPT ); Mon, 21 Sep 2015 12:41:04 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44879 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932159AbbIUQk7 (ORCPT ); Mon, 21 Sep 2015 12:40:59 -0400 Date: Mon, 21 Sep 2015 09:40:05 -0700 From: Mark Brown To: "Opensource [Adam Thomson]" Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Support Opensource , Jason Coughlan Message-ID: <20150921164005.GW30445@sirena.org.uk> References: <381b367e0a4c6c9e00db74f1b0e91d383156ba86.1442500784.git.Adam.Thomson.Opensource@diasemi.com> <20150919171017.GI30445@sirena.org.uk> <2E89032DDAA8B9408CB92943514A0337D460170E@SW-EX-MBX01.diasemi.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4nn+A2p41ba1mxGd" Content-Disposition: inline In-Reply-To: <2E89032DDAA8B9408CB92943514A0337D460170E@SW-EX-MBX01.diasemi.com> X-Cookie: NOBODY EXPECTS THE SPANISH INQUISITION! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 70.35.39.2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio codec X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4nn+A2p41ba1mxGd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2015 at 10:36:04AM +0000, Opensource [Adam Thomson] wrote: > On September 19, 2015 18:10, Mark Brown wrote: > > > +- dlg,cp-mchange : Charge pump voltage tracking mode > > > + ["largest_vol", "dac_vol", "sig_mag"] > > > +- dlg,cp-vol-thresh : Charge pump volume threshold value (6-bit valu= e) > > > + [ 0 - 0x3F ] > > Why are these in the device tree rather than runtime parameters? > From previous internal discussions, these seemed to be fire and forget > parameters, hence their inclusion in the DT binding, rather than as contr= ols. > Personally didn't see either needing runtime updates. Make them runtime configurable. People can do an at boot runtime configuration if they like. >=20 > > > +Required properties: > > > +- interrupt-parent : Specifies the phandle of the interrupt controll= er to which > > > + the IRQs from DA7219 AAD block are delivered to. > > > +- interrupts : IRQ line info for DA7219 AAD block. > > > + (See Documentation/devicetree/bindings/interrupt-controller/interr= upts.txt for > > > + further information relating to interrupt properties) > > Why is this not specified at the device level (the device does not > > appear to support other interrupts)? > Given the way that the driver code was structured, and that the IRQ is on= ly used > for accessory detection, I added it to the child node. The other option w= ould > be to flatten out bindings, and remove the child node. Felt like keeping = the > accessory detect items separate though was a sensible approach. What is y= our > feeling on this? The child node is fine for collecting the parameters but the chip interrupt line should be at the chip level. --4nn+A2p41ba1mxGd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWADLkAAoJECTWi3JdVIfQakwIAIX+ElL/aZogyl8doXykVw6s dBBUIeBR489gE6VyrPYpjMRGE36eRFiKCeGncc5miJCYZ3JgcHJ3EiT/j8CO0hZj Md1I6n344jYorNwwVKZMPqLIMVGx9fACsiI5SrTDKN/YjbEtW9s62C2Q00QNCi0o xCFoCXhcmCsxvGKOs1GOD62KhJL9EC5ygNZPj59uTfIzQck1u42YH0/7YYhP0Wz8 XRXJrVgpza7+He0vwS/uroBEBxmd3M+saiT0+37+UxMQ+Q4ig3wuFH9oQHO5buzq 5m8ifRbaRzSZVOVAMlZiVhSCTOww2kP9mMr63zm9ruae6uRilqobI9+/pFgzLz8= =wuX8 -----END PGP SIGNATURE----- --4nn+A2p41ba1mxGd--