From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757001AbbIUSvU (ORCPT ); Mon, 21 Sep 2015 14:51:20 -0400 Received: from mail.kernel.org ([198.145.29.136]:40687 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756464AbbIUSvQ (ORCPT ); Mon, 21 Sep 2015 14:51:16 -0400 Date: Mon, 21 Sep 2015 11:51:22 -0700 From: Jaegeuk Kim To: nick Cc: cm224.lee@samsung.com, chao2.yu@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: Possible Bug in move_encrypted_block Message-ID: <20150921185122.GD20551@jaegeuk-mac02.mot.com> References: <55FD9D08.5050501@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55FD9D08.5050501@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Sep 19, 2015 at 01:36:08PM -0400, nick wrote: > Greetings Jaeguek and others. > Below are the lines fora possible bug in move_encrypted_block: > err = get_dnode_of_data(&dn, bidx, LOOKUP_NODE); > if (err) > goto out; > Also calls of get_dnode_of_data need to hold the semaphone for the superblock > this call is being done on to avoid concurrent access on data being received IIUC, the f2fs_lock_op() is not neeeded here. Do you mean this? To be honest, I can't catch your point. Thanks, > here from the superblock and file system on disk. In addition unless I get a > reply to this I will not be sending in a bug fix for this. > Nick