From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756988AbbIUTIA (ORCPT ); Mon, 21 Sep 2015 15:08:00 -0400 Received: from mail-yk0-f177.google.com ([209.85.160.177]:36641 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753880AbbIUTH6 (ORCPT ); Mon, 21 Sep 2015 15:07:58 -0400 Date: Mon, 21 Sep 2015 15:07:54 -0400 From: Tejun Heo To: Nicholas Krause Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata:Fix error handling in the function ahci_pci_reset_controller Message-ID: <20150921190754.GF13263@mtj.duckdns.org> References: <1442633267-24297-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442633267-24297-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 11:27:47PM -0400, Nicholas Krause wrote: > This fixes error handling in the function ahci_pci_reset_controller > to properly check if the call to ahci_reset_controller fails and > if return -EIO to this function's caller rather then continuing > with this function's intended work if the controller cannot be > reset properly for this ahci pci based device. Maybe... I don't know. What do we gain by failing resume? Reporting is fine but what'd be the recovery action? Thanks. -- tejun