From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933168AbbIUW4X (ORCPT ); Mon, 21 Sep 2015 18:56:23 -0400 Received: from mail-bn1bon0134.outbound.protection.outlook.com ([157.56.111.134]:2610 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932422AbbIUW4W (ORCPT ); Mon, 21 Sep 2015 18:56:22 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Date: Mon, 21 Sep 2015 17:56:11 -0500 From: Scott Wood To: Zhao Qiang CC: , , , , , , Subject: Re: [PATCH v10 5/5] QE: Move QE from arch/powerpc to drivers/soc Message-ID: <20150921225611.GC12709@home.buserror.net> References: <1442560521-19354-1-git-send-email-qiang.zhao@freescale.com> <1442560521-19354-5-git-send-email-qiang.zhao@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1442560521-19354-5-git-send-email-qiang.zhao@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [2601:448:8100:f9f:d59:7025:7bba:8c10] X-ClientProxiedBy: CY1PR15CA0016.namprd15.prod.outlook.com (25.163.14.26) To BY1PR03MB1483.namprd03.prod.outlook.com (25.162.210.141) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1483;2:dxxrGaF0fhnjh/yymN105i5HK+lyrZ3JbokzcYWpAOV17+Vlb3+nRVOpr/Fx9ROeV7U/D5TuP/u4xzlY5I+rGz9fjkkustw5Gu3nMoQzby4EKEhGIKXQDetU2ElK2UoeHBlz1MCEeXt+pX7DSG8os7SFeTQAUfYvaAgxUQbVC4M=;3:Am7uutYM/DhJyWsdRtkk+Ka8o45SiXqCK0Z+TNHe2X/3lagaWgb/CjfB/Z5O5WEWKGJKlQaabnXZUMD+2FYXY6PnRzMQpJbwO15M78f2/A0HNsYFOW9fLXHrrZEIw3paEKUay53m1fcDSWFfUGzuqA==;25:OwE+tfOdJ7yAKLeY6pIg7dDMrj3rW10C+RKpQEwweQGhnBDBFVaUvtgFL9uG8KUVzZJaIqXHaYr1094NfZzXkxnv1xeQ8KjBqL6nNz9GDaz4vOdpNr17sQY9T0hHnAz2fWd+vBMWQIQrXjrNCV2p3Kxg/hyJYCzTHu7hq8Z4oLN3g5KiyLXZTvPvks5qkEChUgOzWD2yUGC20UGUbyeynzanXbFSCkP4VUDQD0vurREkuK3jhQj573e+QP6QDjGb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1483; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1483;20:Xfz2x1dvl7xojvS4UeyIoaDtYfDqTASKkCg3XxyC17GulEZ4Dyr5NjRgevBtrg7jHPG9Cc398HLB3504HIN/4tqlxUcfdimCxmI9gV8n56wlPlRUBUuUJxpLAqQVgFHstETECg86V2JFPwiCVHRojxJP1BUkKWRHdSqhLIB6RfeK7fG7RgEX72ptOMl0YUcGHMpVWKrhNgzBGzbbzZU+ixQ/dUBfGUL9twmrns+SX9BlWkkwVelGPfJcz3fVXRPjbiGBghLJjlxRPIV6zzi9i9KL2FCfkueAb6vkKK9sbPNNum359iW8iHHW9yg3DGQb1IsD8hU2bFyY1G2iYQQmhOobrho0YhMpm3ElPwWBYy7H1ekb4Xo0pxOx9FrGRWcvZX0mrYP9DXPfJqWCYzW7B/k8RjaaFOw1P0SuSFMf0ze5fWvByOgqU9HMILdGMkzv00Y3+Wcq7nLdp8r5rM6xNNjZ+oQ7L6vIqkodhILk4loVPDzQNEz3uH0PP6dEe1zT;4:wHt9wp6+WmTkTIdf3rnZKESogovfu2jQKevyUfKEzKarr8NDxtx85qd+BV05UuLsuExaC6CZ9LALZd92+uyWCiC2opE1PYF7+kCjrdsXp2LwS0RLnwBXvucWWHg8qaCiSCrvSN/CDtsELWHUHDu8Vl0r8Ry1MDvNViGrJMcG6cnqfklJ/P1LbKHAZdgBqaIElqi6Gj1MkX15fZZDhZCQOSFEduZXjCIVxWSruL60bwM= X-Exchange-Antispam-Report-CFA: BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1483;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1483; X-Forefront-PRVS: 07063A0A30 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(189002)(199003)(87976001)(62966003)(64706001)(101416001)(110136002)(189998001)(77096005)(105586002)(68736005)(83506001)(106356001)(5001860100001)(97736004)(4001540100001)(4001450100002)(5001830100001)(4001350100001)(50466002)(81156007)(40100003)(5004730100002)(23726002)(97756001)(46102003)(2950100001)(122386002)(54356999)(50986999)(76176999)(92566002)(46406003)(33656002)(69596002)(42186005)(53416004)(86362001)(77156002)(47776003)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1483;H:home.buserror.net;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR03MB1483;23:rTuMliTwTX5LgRgssHO+h25wsNJY2/kC4ZsUXb+zJ?= =?us-ascii?Q?q7pKVSol+csD/0jjE+rf+AhCMp58XMbN9MB+N6G6r7DK7VBlbN5gkisA0AKU?= =?us-ascii?Q?arZpwlgWrRZhjHRF674+hOq8vZXGVshBrmKZCVS57JRu097V92HE4V59V/Nw?= =?us-ascii?Q?jNRzIdEfIQS7Nnar0G1cbxCrsrU2mO0YR1vqrk2yoti+I1AxfppvY2ESntXf?= =?us-ascii?Q?spmxiNXgKSczF1Vg/SL6ZDbS0GFZGP7bb5cSdH8nU8RVxlYsMyg0IvOYLDBO?= =?us-ascii?Q?L8LRJqkxuonpMMn/zolPWnAZSWyZjf4wavH2uSNKakqiHrrb2hYEegN93aEd?= =?us-ascii?Q?koyGXz5yd3ZAyAsd3L7/JxbDNOokFjtaEaWg96Nd77nXtsSCE+11/icJft0o?= =?us-ascii?Q?GuYUZzBY2vl7fDYHcCmOy9BPmrG2LvV17bMp5eUVJJsrcdb1n0tZlnCZ8wkz?= =?us-ascii?Q?MDNDfB+5o3VYkbNvLk74mzMB5D8ptOQJFVybOBCxGNMJ7ha/ObCoKNotpDF2?= =?us-ascii?Q?J4J8bkFd5+NEwCHOJyjwBLFnCrCDbZee9MLJrpsyeNWN+4FusryR+XHf8NRS?= =?us-ascii?Q?P9kwG38vDXUj5eT/+une6RM81MufGrHBcRHyWht79VHPtUjwf4vUSrNFVu7c?= =?us-ascii?Q?ZfASb9MagOzSFo4MRzai+sM/+gNeTobaTbEEdpiIYsFdV0F5eIQjbdrbe0vm?= =?us-ascii?Q?3s8lkF8R/ImFEaAJaJ/3HYQkiFWYN/xiyyLKyOVr3rGssU4W/Oju7vk+lS/M?= =?us-ascii?Q?vII+V6KaYsiEvQL4frL24T5O4/gW7orHJtrkQzDo8ydvlGhhYPJZ+gCOUN9d?= =?us-ascii?Q?JihBo2enY4e50DYQtOUUxqZBpKVJ10KmIMXTTdPQNHhRzQQZOd9ry9DNtrqa?= =?us-ascii?Q?EogZp3Uq8SKKP0kS6sUyyjla2vWPCo0rolqq7NGtTNeHqfiAoR/e6JhRS2BU?= =?us-ascii?Q?zwIikgpvGv2krihcr/FRcE6uJ+QNz4iMO8MRCqnMl6M71At+A/4DXhYr6Orf?= =?us-ascii?Q?xj+ZeI2hWQt3RdfFGVLpo2efyL4UBn51GVd0EFg+I0q2QH1kRlchkI2ocavO?= =?us-ascii?Q?mvBbdXkE/StZ5LamuPile0/xrOkf2VQ459eAf39COmHe0w5hhR4260GjAvY2?= =?us-ascii?Q?BqIIZ46i+rcvEWSwo92jeyiuETvBv7q?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1483;5:zeJVBiDy/sjU9UWR0KBIy6iIKZjT2n1eQvCmMKXZhFxPkomH4nWZ8r4HSIhxp3EWFC+dA/JExJeu4Rq9GWfydf8dDYVcWZ9buSt3QTHFMB/+lR/YKu2eBZVAsu942M8mzYehLopanFahRPBkmORx5g==;24:8hITDhtcdR9WiVwmfKRgmVVZSedIjWW+tcpbBjJyGF4IgbD0uOj/OY1piAajVhlpCABAr8u6+5rTuqmkHQOyn1p4N3HBnAot4FF5DHBwF8w=;20:9X78rTBwTDvqaGMJpRHgxWjCWEGzt7lZ14Nl9jqqqIkOyWAXTik4NLt9XPCIxg1ZRznj+nDZ5Uj9TGROCgxHkg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2015 22:56:19.3411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1483 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 03:15:21PM +0800, Zhao Qiang wrote: > diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig > new file mode 100644 > index 0000000..3012571 > --- /dev/null > +++ b/drivers/soc/fsl/qe/Kconfig > @@ -0,0 +1,33 @@ > +# > +# QE Communication options > +# > + > +config QUICC_ENGINE > + bool "Freescale QUICC Engine (QE) Support" > + depends on FSL_SOC && PPC32 > + select PPC_LIB_RHEAP > + select GENERIC_ALLOCATOR > + select CRC32 Why is "select PPC_LIB_RHEAP" still here? > + help > + The QUICC Engine (QE) is a new generation of communications > + coprocessors on Freescale embedded CPUs (akin to CPM in older chips). > + Selecting this option means that you wish to build a kernel > + for a machine with a QE coprocessor. > + > +config UCC_SLOW > + bool > + default y if SERIAL_QE > + help > + This option provides qe_lib support to UCC slow > + protocols: UART, BISYNC, QMC > + > +config UCC_FAST > + bool > + default y if UCC_GETH > + help > + This option provides qe_lib support to UCC fast > + protocols: HDLC, Ethernet, ATM, transparent What does "qe_lib" mean to the end user, or to anyone after the code is moved to drivers/soc/fsl/qe? -Scott