From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757374AbbIVHDv (ORCPT ); Tue, 22 Sep 2015 03:03:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41059 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757275AbbIVHDu (ORCPT ); Tue, 22 Sep 2015 03:03:50 -0400 Date: Tue, 22 Sep 2015 09:03:40 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Ingo Molnar , linux-kernel@vger.kernel.org, Wang Nan , Brendan Gregg , Daniel Borkmann , David Ahern , He Kuang , Kaixu Xia , Masami Hiramatsu , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Zefan Li , pi3orama@163.com, Arnaldo Carvalho de Melo Subject: Re: [PATCH 8/8] perf tools: Make perf depend on libbpf Message-ID: <20150922070340.GH29091@krava.redhat.com> References: <1442870601-26004-1-git-send-email-acme@kernel.org> <1442870601-26004-9-git-send-email-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442870601-26004-9-git-send-email-acme@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 06:23:21PM -0300, Arnaldo Carvalho de Melo wrote: > From: Wang Nan > > By adding libbpf into perf's Makefile, this patch enables perf to build > libbpf during building if libelf is found and neither NO_LIBELF nor > NO_LIBBPF is set. The newly introduced code is similar to libapi and > libtraceevent building in Makefile.perf. > > MANIFEST is also updated for 'make perf-*-src-pkg'. > > Append make_no_libbpf to tools/perf/tests/make. > > 'bpf' feature check is appended into default FEATURE_TESTS and > FEATURE_DISPLAY, so perf will check API version of bpf in > /path/to/kernel/include/uapi/linux/bpf.h. Which should not fail except > when we are trying to port this code to an old kernel. > > Error messages are also updated to notify users about the disable of BPF > support of 'perf record' if libelf is missed or BPF API check failed. > > tools/lib/bpf is added into TAG_FOLDERS to allow us to navigate on > libbpf files when working on perf using tools/perf/tags. > > Signed-off-by: Wang Nan > Acked-by: Alexei Starovoitov > Cc: Brendan Gregg > Cc: Daniel Borkmann > Cc: David Ahern > Cc: He Kuang > Cc: Jiri Olsa > Cc: Kaixu Xia > Cc: Masami Hiramatsu > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra > Cc: Zefan Li > Cc: pi3orama@163.com > Link: http://lkml.kernel.org/r/1441523623-152703-3-git-send-email-wangnan0@huawei.com > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/build/Makefile.feature | 6 ++++-- > tools/perf/MANIFEST | 3 +++ > tools/perf/Makefile.perf | 19 +++++++++++++++++-- > tools/perf/config/Makefile | 19 ++++++++++++++++++- > tools/perf/tests/make | 4 +++- > 5 files changed, 45 insertions(+), 6 deletions(-) > missing doc hunk in Makefile.perf jirka --- diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 8af786f458df..bb949c9e818a 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -75,6 +75,8 @@ include config/utilities.mak # Define NO_LZMA if you do not want to support compressed (xz) kernel modules # # Define NO_AUXTRACE if you do not want AUX area tracing support +# +# Define NO_BPF if you do not want BPF support # As per kernel Makefile, avoid funny character set dependencies unexport LC_ALL