From: Andrew Morton <akpm@linux-foundation.org>
To: Baoquan He <bhe@redhat.com>
Cc: yinghai@kernel.org, dyoung@redhat.com, jroedel@suse.de,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
Date: Tue, 22 Sep 2015 17:08:50 -0700 [thread overview]
Message-ID: <20150922170850.d46e58d9.akpm@linux-foundation.org> (raw)
In-Reply-To: <20150923000255.GA2569@dhcp-17-102.nay.redhat.com>
On Wed, 23 Sep 2015 08:02:55 +0800 Baoquan He <bhe@redhat.com> wrote:
> >
> > > }
> > >
> > > low_base = memblock_find_in_range(low_size, (1ULL<<32),
> > > low_size, alignment);
> > >
> > > if (!low_base) {
> > > - if (!auto_set)
> > > - pr_info("crashkernel low reservation failed - No suitable area found.\n");
> > > -
> > > - return;
> > > + pr_info("crashkernel low reservation failed - No suitable area found.\n");
> >
> > That's not a terribly useful message. If kdump is now unavailable and
> > the operator needs to take some remedial action then we should inform
> > them of this.
> >
> > Also, such a message should have higher severity than KERN_INFO?
>
> Yes, how about KERN_ERR? It's an unexpected result from kdump side
> though it doesn't harm the normal kernel.
Sure, KERN_ERR is good. Along with more useful message text.
next prev parent reply other threads:[~2015-09-23 0:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 11:48 Baoquan He
2015-09-22 13:50 ` Baoquan He
2015-09-22 19:54 ` Andrew Morton
2015-09-23 0:02 ` Baoquan He
2015-09-23 0:08 ` Andrew Morton [this message]
2015-09-23 0:20 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922170850.d46e58d9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@suse.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome