From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758207AbbIVRXK (ORCPT ); Tue, 22 Sep 2015 13:23:10 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:46366 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752839AbbIVRXI (ORCPT ); Tue, 22 Sep 2015 13:23:08 -0400 Date: Tue, 22 Sep 2015 12:23:02 -0500 From: Felipe Balbi To: Krzysztof Opasiak CC: , , , , Subject: Re: [PATCH 1/2] usb: gadget: loopback: fix: Don't share qlen and buflen between instances Message-ID: <20150922172302.GB7094@saruman.tx.rr.com> Reply-To: References: <1442939967-4168-1-git-send-email-k.opasiak@samsung.com> <20150922165324.GA7094@saruman.tx.rr.com> <560188A5.9010201@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LpQ9ahxlCli8rRTG" Content-Disposition: inline In-Reply-To: <560188A5.9010201@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LpQ9ahxlCli8rRTG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 22, 2015 at 06:58:13PM +0200, Krzysztof Opasiak wrote: >=20 >=20 > On 09/22/2015 06:53 PM, Felipe Balbi wrote: > >On Tue, Sep 22, 2015 at 06:39:26PM +0200, Krzysztof Opasiak wrote: > >>Each instance of loopback function may have different qlen > >>and buflen attributes values. When linking function to > >>configuration those values had been assigned to global > >>variables. Linking other instance to config overwrites those > >>values. > >> > >>This commit moves those values to f_loopback structure > >>to avoid overwriting. Now each function has its own instance > >>of those values. > >> > >>Cc: # 3.10+ > >>Signed-off-by: Krzysztof Opasiak > > > >looks like you missed linux-usb on both patches. Care to resend ? > > >=20 > Sorry, just send v2 without reading your email because I have found some = mem > leak. I will resend v2 with cc to linux-usb. Thanks :-) --=20 balbi --LpQ9ahxlCli8rRTG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWAY52AAoJEIaOsuA1yqREBtwQALNs30GtsvvS3OD85GYqOAc2 +xLLXuwmcS1iknzX96k26jt2ZULMuQ6WupweuVTQG+fTp8zt2kVgHyN9q+B5fel3 CpGe4JewUEXvRWoxAkX6dtkldcqnMed3ouafYxniiFcm4h2hEbQCwW+In88WJVzx eRV84+xiaDYdVII4BicVT7ygWaBSJjZyrKEQal1ciNETjr3Zv0MSv880Wge5bF24 DOy7rCo+FxmcknDiINHqf6DJuW4wjrnLaQPQ0XrsCZxPBVUOWUelk9S9vRp6qoq4 IrdHxiZmfgw8tbEmNAUxa17+tn435cNRJoHUGVMqCmQuVm0pFM2noii2ymkhdL3f Y4uhRexTWgBg0SeXjwwVlRnhXAmrM5H7V0BShAfs1PC01rSToheJodCU3XFLlWqI NBawVVH1YAPNhKNzrXvjpoe9n2U+JaSPivOkR1NgnfypUx9mQztBB7AWsiXGYbK+ 9GvJ0wnY7OCdFUik6shEAMIat2QcOXYCcQ4VPWyGLNvAicXVU3Am2A0VmWMhcHHx HnuXIdJqJPq4xO6cG8RSuRVouwfAPUSY2hO/0X+7mtPty61QcQ4IAF7WMZ/PSPkP eBkCeS8Q6prp4kUyLcWU92RPvVPYjl7TKRdPIKTSYNtlcn+xjMlE3ZWV5o5Bhf6W wxeVoZzTOy8bdp+JgMQo =E89A -----END PGP SIGNATURE----- --LpQ9ahxlCli8rRTG--