From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934415AbbIVTMl (ORCPT ); Tue, 22 Sep 2015 15:12:41 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:41623 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758911AbbIVTKw (ORCPT ); Tue, 22 Sep 2015 15:10:52 -0400 Date: Tue, 22 Sep 2015 21:02:43 +0200 From: Andrew Lunn To: Jacek Anaszewski Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, sakari.ailus@linux.intel.com, stsp@users.sourceforge.net, pavel@ucw.cz, ospite@studenti.unina.it, davem@davemloft.net, linus.walleij@linaro.org, ricardo.ribalda@gmail.com, p.meerwald@bct-electronic.com Subject: Re: [PATCH 4/5] leds: core: Add an internal led_set_brightness_nosleep function Message-ID: <20150922190243.GD20029@lunn.ch> References: <1442400464-27367-1-git-send-email-j.anaszewski@samsung.com> <1442400464-27367-5-git-send-email-j.anaszewski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442400464-27367-5-git-send-email-j.anaszewski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +void led_set_brightness_nosleep(struct led_classdev *led_cdev, > + enum led_brightness value) > +{ > + led_cdev->brightness = min(value, led_cdev->max_brightness); > + > + if (led_cdev->flags & LED_SUSPENDED) > + return; > + > + /* Use brightness_set op if available, it is guaranteed not to sleep */ > + if (led_cdev->brightness_set) > + led_cdev->brightness_set(led_cdev, led_cdev->brightness); > + > + /* If brightness setting can sleep, delegate it to a work queue task */ > + led_cdev->delayed_set_value = led_cdev->brightness; > + schedule_work(&led_cdev->set_brightness_work); > +} To me, it looks like there is a missing else, or return here. We don't want both led_cdev->brightness_set() and the work queue. > +EXPORT_SYMBOL(led_set_brightness_nosleep); There seems to be a mixture of EXPORT_SYMBOL and EXPORT_SYMBOL_GPL. Have you figured out the pattern? led-class.c seems to be all _GPL, but led-core.c has a mixture. Andrew