From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935059AbbIVWx5 (ORCPT ); Tue, 22 Sep 2015 18:53:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:56695 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934970AbbIVWx4 (ORCPT ); Tue, 22 Sep 2015 18:53:56 -0400 Date: Tue, 22 Sep 2015 15:53:52 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix to correct freed section number during gc Message-ID: <20150922225352.GA31427@jaegeuk-mac02.mot.com> References: <00d601d0f539$3d893e90$b89bbbb0$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00d601d0f539$3d893e90$b89bbbb0$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chao, On Tue, Sep 22, 2015 at 09:18:18PM +0800, Chao Yu wrote: > We pass 'nfree' to has_not_enough_free_secs to check whether there is > enough free section, but 'nfree' indicates the number of segment gced, > should alter the value to section number. Yeah, but I think we need to increase nfree only when an entire section is gced completely, since sometimes nfree can be increased across sections. Thanks, > > Signed-off-by: Chao Yu > --- > fs/f2fs/gc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index e932740..7ad2a60 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -817,7 +817,8 @@ gc_more: > if (unlikely(f2fs_cp_error(sbi))) > goto stop; > > - if (gc_type == BG_GC && has_not_enough_free_secs(sbi, nfree)) { > + if (gc_type == BG_GC && > + has_not_enough_free_secs(sbi, nfree / sbi->segs_per_sec)) { > gc_type = FG_GC; > if (__get_victim(sbi, &segno, gc_type) || prefree_segments(sbi)) > write_checkpoint(sbi, &cpc); > @@ -839,7 +840,7 @@ gc_more: > if (gc_type == FG_GC) > sbi->cur_victim_sec = NULL_SEGNO; > > - if (has_not_enough_free_secs(sbi, nfree)) > + if (has_not_enough_free_secs(sbi, nfree / sbi->segs_per_sec)) > goto gc_more; > > if (gc_type == FG_GC) > -- > 2.5.2