From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753728AbbIWSFw (ORCPT ); Wed, 23 Sep 2015 14:05:52 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:44212 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753392AbbIWSFu (ORCPT ); Wed, 23 Sep 2015 14:05:50 -0400 Date: Wed, 23 Sep 2015 11:05:49 -0700 (PDT) Message-Id: <20150923.110549.113067983983388057.davem@davemloft.net> To: ivan@ru.ibm.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, ben@decadent.org.uk Subject: Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool From: David Miller In-Reply-To: <20150923144222.66de305c@fr-ThinkPad-W520> References: <20150923144222.66de305c@fr-ThinkPad-W520> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 23 Sep 2015 11:05:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ivan Mikhaylov Date: Wed, 23 Sep 2015 14:42:22 +0400 > Register dump out work preventing with > old ethtool + new driver and new ethtool + old driver. First of all you didn't provide a proper Signoff. Second of all, there was so much discussion about whether this does or does not break things for various combinations of old/new ethtool and kernel. Therefore I want a real detailed commit message that explains why this is all OK. After so much confusion and discussion, providing a patch with absolutely no commit message is completely inappropriate.