From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756117AbbIWXYX (ORCPT ); Wed, 23 Sep 2015 19:24:23 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46469 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755014AbbIWXYV (ORCPT ); Wed, 23 Sep 2015 19:24:21 -0400 Date: Wed, 23 Sep 2015 16:24:17 -0700 (PDT) Message-Id: <20150923.162417.814596822188458346.davem@davemloft.net> To: linux@arm.linux.org.uk Cc: f.fainelli@gmail.com, devicetree@vger.kernel.org, frowand.list@gmail.com, grant.likely@linaro.org, isubramanian@apm.com, kchudgar@apm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, leoli@freescale.com, michal.simek@xilinx.com, netdev@vger.kernel.org, rric@kernel.org, robh+dt@kernel.org, soren.brinkmann@xilinx.com, sgoutham@cavium.com, thomas.petazzoni@free-electrons.com Subject: Re: [PATCH v2 0/9] Phy, mdiobus, and netdev struct device fixes From: David Miller In-Reply-To: <20150922161710.GA21084@n2100.arm.linux.org.uk> References: <20150922161710.GA21084@n2100.arm.linux.org.uk> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 23 Sep 2015 16:24:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8NNOSdp019446 From: Russell King - ARM Linux Date: Tue, 22 Sep 2015 17:17:10 +0100 > This is the second version of the series, with the comments David had > on the first patch fixed up. Original series description with updated > diffstat below. This needs some build fixes: drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function xgene_enet_phy_connect: drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:694:20: error: too few arguments to function of_phy_connect pdata->phy_dev = of_phy_connect(ndev, phy_np, ^ In file included from drivers/net/ethernet/apm/xgene/xgene_enet_main.h:31:0, from drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:22: include/linux/of_mdio.h:18:27: note: declared here extern struct phy_device *of_phy_connect(struct net_device *dev, ^ {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I