From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934911AbbIWFoB (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Sep 2015 01:44:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45919 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751663AbbIWFnz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Sep 2015 01:43:55 -0400
Date: Wed, 23 Sep 2015 13:44:34 +0800
From: Minfei Huang <mhuang@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, kexec@lists.infradead.org,
        Minfei Huang <mnfhuang@gmail.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] kexec: Add prefix "kexec" to output message
Message-ID: <20150923054434.GA3147@dhcp-128-25.nay.redhat.com>
References: <1442128512-32578-1-git-send-email-mnfhuang@gmail.com>
 <87fv2il0rq.fsf@x220.int.ebiederm.org>
 <20150914075056.GA13324@t440s.lenovo>
 <20150914084400.GA7953@localhost.localdomain>
 <20150915030804.GA7690@t440s.lenovo>
 <20150922160704.GA10225@dhcp-128-25.nay.redhat.com>
 <20150923013723.GA4394@dhcp-129-160.nay.redhat.com>
 <20150923024933.GB3166@dhcp-17-102.nay.redhat.com>
 <20150923051419.GA21804@dhcp-128-25.nay.redhat.com>
 <20150923052622.GB7739@dhcp-17-102.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150923052622.GB7739@dhcp-17-102.nay.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/23/15 at 01:26pm, Baoquan He wrote:
> On 09/23/15 at 01:14pm, Minfei Huang wrote:
> > On 09/23/15 at 10:49am, Baoquan He wrote:
> > > This is weird, user really don't need to know each file. I saw you added
> > > a new file kexec_internal.h and all three files includes it. Why not doing
> > > it there to make it the same as before?
> > 
> > The output message format is incorrect, if other *.c (except for kexec*)
> > include the kexec_internal.h.
> 
> No, I assume Dave added kexec_internal.h not to be used by other *.c.
> It should be only used by kexec*.c
> 
> > 
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > 
> > How about defining the format like above in each *.c?

Ok. I can split this patch as two patches One for cleanup, other to fix
the prefix issue.

Thanks
Minfei