From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbbIWRzR (ORCPT ); Wed, 23 Sep 2015 13:55:17 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47410 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbbIWRzN (ORCPT ); Wed, 23 Sep 2015 13:55:13 -0400 Date: Wed, 23 Sep 2015 09:45:32 -0700 From: Mark Brown To: Chen-Yu Tsai Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Maxime Ripard , Russell King , linux-sunxi@googlegroups.com, Hans de Goede , shuge@allwinnertech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20150923164532.GT30445@sirena.org.uk> References: <1443024323-9115-1-git-send-email-wens@csie.org> <1443024323-9115-3-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rfCqmLcWnxF2yz6F" Content-Disposition: inline In-Reply-To: <1443024323-9115-3-git-send-email-wens@csie.org> X-Cookie: NOBODY EXPECTS THE SPANISH INQUISITION! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 70.35.39.2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 2/5] soc: sunxi: Add driver for Allwinner Reduced Serial Bus X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rfCqmLcWnxF2yz6F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 24, 2015 at 12:05:18AM +0800, Chen-Yu Tsai wrote: > +static int sunxi_rsb_device_probe(struct device *dev) > +{ > + const struct sunxi_rsb_driver *drv = to_sunxi_rsb_driver(dev->driver); > + struct sunxi_rsb_device *rdev = to_sunxi_rsb_device(dev); > + int ret; > + > + if (dev->bus != &sunxi_rsb_bus) > + return 0; That's a bit worrying... why might this get called for something other than a rsb device? > +struct regmap *devm_regmap_init_sunxi_rsb(struct sunxi_rsb_device *rdev, > + const struct regmap_config *config); This should work most of the time but you might want to take a look at the changes introduced in 3cfe7a74d42b (regmap: Use different lockdep class for each regmap init call) and follow a similar pattern for RSB to avoid spurious lockdep warnings in some configurations - see the commit log for that change for a full explanation. Otherwise the regmap bit of this looks good, I'll try to have another look through at the rest of the code later. --rfCqmLcWnxF2yz6F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWAtcmAAoJECTWi3JdVIfQvjoH/11PB3HabGfQJOgOQk2Tdbx4 owFYAwNUc5BVVV1Pxx2NulnxoA7lWH+wVWGC7UpvQ3wxffKbFngTb2jQsJx5P3hf t7Q5a/xqhvV/lL2TBUUlMsrWvIIPyMyzewMK6A4LONmkPg3gpyjGaGsNquvgnyNk dK9vcOKq1t0g6MXWJyk9udrHu6kd1hfoPzW+Y4BUHlkYzkpkMwW3auYKBJzBQ6cJ BniPuhuNz7VYVQwBQnSZ4GO2SspN6qVBlXdDaXK2p4kGG0aBOr4u73QgLpg5BFvv rbcL2kZ5MOCp+zVhSq98SrLpXak2LqtJpQFPmgUJ4Qf/IWn5UjLigOm9XzbRKCc= =7Aq1 -----END PGP SIGNATURE----- --rfCqmLcWnxF2yz6F--