From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756177AbbIWRSw (ORCPT ); Wed, 23 Sep 2015 13:18:52 -0400 Received: from jptorel01.sonyericsson.com ([124.215.201.70]:13957 "EHLO jptorel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755787AbbIWRSv (ORCPT ); Wed, 23 Sep 2015 13:18:51 -0400 Date: Wed, 23 Sep 2015 10:18:40 -0700 From: Bjorn Andersson To: Andy Gross CC: "linux-arm-msm@vger.kernel.org" , Mark Brown , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [Patch v2 02/10] soc: qcom: smd-rpm: Add existing platform support Message-ID: <20150923171840.GD24668@usrtlx11787.corpusers.net> References: <1443027209-19444-1-git-send-email-agross@codeaurora.org> <1443027209-19444-3-git-send-email-agross@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1443027209-19444-3-git-send-email-agross@codeaurora.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 23 Sep 09:53 PDT 2015, Andy Gross wrote: > This patch adds support for all current Qualcomm platforms which utilize > RPM over SMD. This includes both MSM8916 and APQ8084. > > Signed-off-by: Andy Gross > --- > .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 2 ++ > drivers/soc/qcom/smd-rpm.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt > index 3710dd5..7d05246 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt > @@ -20,6 +20,8 @@ resources. > Value type: > Definition: must be one of: > "qcom,rpm-msm8974" > + "qcom,rpm-msm8916" > + "qcom,rpm-apq8084" > > - qcom,smd-channels: > Usage: required > diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c > index 1392ccf..455083c 100644 > --- a/drivers/soc/qcom/smd-rpm.c > +++ b/drivers/soc/qcom/smd-rpm.c > @@ -212,6 +212,8 @@ static void qcom_smd_rpm_remove(struct qcom_smd_device *sdev) > > static const struct of_device_id qcom_smd_rpm_of_match[] = { > { .compatible = "qcom,rpm-msm8974" }, > + { .compatible = "qcom,rpm-msm8916" }, > + { .compatible = "qcom,rpm-apq8084" }, > {} This is now how the alphabet works, please update the order and add: Reviewed-by: Bjorn Andersson Regards, Bjorn