From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbbIWRYH (ORCPT ); Wed, 23 Sep 2015 13:24:07 -0400 Received: from jptorel01.sonyericsson.com ([124.215.201.70]:15196 "EHLO jptorel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932074AbbIWRYF (ORCPT ); Wed, 23 Sep 2015 13:24:05 -0400 X-Greylist: delayed 314 seconds by postgrey-1.27 at vger.kernel.org; Wed, 23 Sep 2015 13:24:05 EDT Date: Wed, 23 Sep 2015 10:23:58 -0700 From: Bjorn Andersson To: Andy Gross CC: "linux-arm-msm@vger.kernel.org" , Mark Brown , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [Patch v2 06/10] regulators: qcom-smd: Add PM8916 support Message-ID: <20150923172358.GE24668@usrtlx11787.corpusers.net> References: <1443027209-19444-1-git-send-email-agross@codeaurora.org> <1443027209-19444-7-git-send-email-agross@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1443027209-19444-7-git-send-email-agross@codeaurora.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 23 Sep 09:53 PDT 2015, Andy Gross wrote: > This patch adds support and documentation for the PM8916 regulators > found on MSM8916 platforms. > > Signed-off-by: Andy Gross > --- > .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 18 ++++++ > drivers/regulator/qcom_smd-regulator.c | 64 ++++++++++++++++++++ > 2 files changed, 82 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt > index 7084474..05dfc1a 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt > @@ -18,6 +18,7 @@ Regulator nodes are identified by their compatible: > Definition: must be one of: > "qcom,rpm-pm8841-regulators" > "qcom,rpm-pm8941-regulators" > + "qcom,rpm-pm8916-regulators" Alphabetical please > > - vdd_s1-supply: > - vdd_s2-supply: > @@ -50,6 +51,19 @@ Regulator nodes are identified by their compatible: > Definition: reference to regulator supplying the input pin, as > described in the data sheet > > +- vdd_s1-supply: > +- vdd_s2-supply: > +- vdd_s3-supply: > +- vdd_s4-supply: > +- vdd_l1_l2_l3-supply > +- vdd_l4_l5_l6-supply > +- vdd_l7-supply End these with ':' as well > +- vdd_l8_l9_l10_l11_l12_l13_l14_l15_l16_l17_l18-supply: > + Usage: optional (pm8916 only) > + Value type: > + Definition: reference to regulator supplying the input pin, as > + described in the data sheet > + [..] > diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c [..] > static const struct of_device_id rpm_of_match[] = { > + { .compatible = "qcom,rpm-pm8916-regulators", .data = &rpm_pm8916_regulators }, pm8916 > pm8841 > { .compatible = "qcom,rpm-pm8841-regulators", .data = &rpm_pm8841_regulators }, > { .compatible = "qcom,rpm-pm8941-regulators", .data = &rpm_pm8941_regulators }, > {} With these nits: Acked-by: Bjorn Andersson Regards, Bjorn