From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932123AbbIXVXQ (ORCPT ); Thu, 24 Sep 2015 17:23:16 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54234 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932071AbbIXVXO (ORCPT ); Thu, 24 Sep 2015 17:23:14 -0400 Date: Thu, 24 Sep 2015 14:23:13 -0700 (PDT) Message-Id: <20150924.142313.529174195447744153.davem@davemloft.net> To: sudeep.holla@arm.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, rjw@rjwysocki.net, claudiu.manoil@freescale.com, haokexin@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag From: David Miller In-Reply-To: <1442850433-5903-14-git-send-email-sudeep.holla@arm.com> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-14-git-send-email-sudeep.holla@arm.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Sep 2015 14:23:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudeep Holla Date: Mon, 21 Sep 2015 16:47:09 +0100 > The device is set as wakeup capable using proper wakeup API but the > driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source > which is incorrect. > > This patch removes the use of IRQF_NO_SUSPEND flags replacing it with > enable_irq_wake instead. > > Cc: "David S. Miller" > Cc: Claudiu Manoil > Cc: Kevin Hao > Cc: netdev@vger.kernel.org > Signed-off-by: Sudeep Holla Applied, thanks.