From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756711AbbIXPNk (ORCPT ); Thu, 24 Sep 2015 11:13:40 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38605 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756286AbbIXPNh (ORCPT ); Thu, 24 Sep 2015 11:13:37 -0400 Date: Thu, 24 Sep 2015 17:16:29 +0200 From: Daniel Vetter To: Geliang Tang Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: drm_atomic_crtc_get_property should be static Message-ID: <20150924151629.GU3383@phenom.ffwll.local> Mail-Followup-To: Geliang Tang , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <35616aa394f49044c65e9fcc53f31894ad425873.1443115283.git.geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35616aa394f49044c65e9fcc53f31894ad425873.1443115283.git.geliangtang@163.com> X-Operating-System: Linux phenom 4.1.0-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 03:01:03AM -0700, Geliang Tang wrote: > Fixes the following sparse warning: > drivers/gpu/drm/drm_atomic.c:442:5: warning: symbol > 'drm_atomic_crtc_get_property' was not declared. Should it be static? > > Signed-off-by: Geliang Tang Applied to drm-misc, thansk. -Daniel > --- > drivers/gpu/drm/drm_atomic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index 940f80b..7bb3845 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -438,7 +438,8 @@ EXPORT_SYMBOL(drm_atomic_crtc_set_property); > * consistent behavior you must call this function rather than the > * driver hook directly. > */ > -int drm_atomic_crtc_get_property(struct drm_crtc *crtc, > +static int > +drm_atomic_crtc_get_property(struct drm_crtc *crtc, > const struct drm_crtc_state *state, > struct drm_property *property, uint64_t *val) > { > -- > 1.9.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch