From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752956AbbIXUFQ (ORCPT ); Thu, 24 Sep 2015 16:05:16 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:46976 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbbIXUFO (ORCPT ); Thu, 24 Sep 2015 16:05:14 -0400 Date: Thu, 24 Sep 2015 16:05:04 -0400 From: Johannes Weiner To: Mel Gorman Cc: Andrew Morton , Rik van Riel , Vlastimil Babka , David Rientjes , Joonsoo Kim , Michal Hocko , Linux-MM , LKML Subject: Re: [PATCH 02/10] mm, page_alloc: Remove unnecessary recalculations for dirty zone balancing Message-ID: <20150924200504.GF3009@cmpxchg.org> References: <1442832762-7247-1-git-send-email-mgorman@techsingularity.net> <1442832762-7247-3-git-send-email-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442832762-7247-3-git-send-email-mgorman@techsingularity.net> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 11:52:34AM +0100, Mel Gorman wrote: > File-backed pages that will be immediately written are balanced between > zones. This heuristic tries to avoid having a single zone filled with > recently dirtied pages but the checks are unnecessarily expensive. Move > consider_zone_balanced into the alloc_context instead of checking bitmaps > multiple times. The patch also gives the parameter a more meaningful name. > > Signed-off-by: Mel Gorman > Acked-by: David Rientjes > Acked-by: Michal Hocko > Acked-by: Vlastimil Babka Acked-by: Johannes Weiner