mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Dexuan Cui <decui@microsoft.com>
Cc: "dedekind1@gmail.com" <dedekind1@gmail.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"lizefan@huawei.com" <lizefan@huawei.com>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	"kernel-team@fb.com" <kernel-team@fb.com>,
	"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies
Date: Thu, 24 Sep 2015 16:47:36 -0400	[thread overview]
Message-ID: <20150924204736.GG25415@mtj.duckdns.org> (raw)
In-Reply-To: <d6cf09f352a84b8d811da55fbc64a869@SIXPR30MB031.064d.mgd.msft.net>

Hello,

On Thu, Sep 24, 2015 at 08:40:18AM +0000, Dexuan Cui wrote:
> I can confirm the patch fixes my "slow write" issue too.
> 
> Tested-by: Dexuan Cui <decui@microsoft.com>

Yeah, this should make it go away w/o using cgroup writeback
explicitly; however, I think the proper solution for cgroup writeback
is moving bandwidth estimation from memory domain to io domain so that
two separate bw estimations wouldn't interfere with each other leading
to unexpected outcomes.  I'll work on the changes.

Thanks.

-- 
tejun

  reply	other threads:[~2015-09-24 20:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 22:53 [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
2015-06-16 22:53 ` [PATCH 1/2] ext4: replace ext4_io_submit->io_op with ->io_wbc Tejun Heo
2015-07-22  3:56   ` Theodore Ts'o
2015-06-16 22:53 ` [PATCH 2/2] ext4: implement cgroup writeback support Tejun Heo
2015-07-22  3:56   ` Theodore Ts'o
2015-09-23 12:49     ` Artem Bityutskiy
2015-09-23 13:50       ` Artem Bityutskiy
2015-09-23 17:02         ` Theodore Ts'o
2015-09-23 17:57           ` Tejun Heo
2015-09-23 17:25       ` Chris Mason
     [not found]         ` <CAF4G-tKEcnVw76-ZU77AjmBDGybLnNEOKjkJtYBN67es0wb30g@mail.gmail.com>
2015-09-23 17:53           ` Chris Mason
2015-09-23 18:24             ` Theodore Ts'o
     [not found]               ` <CAF4G-t+E89a_A3RzQYB9wXxqE6nM0t7wN6fNmLABZ70=ivHTRQ@mail.gmail.com>
2015-09-23 19:47                 ` Artem Bityutskiy
2015-09-23 20:48                   ` Theodore Ts'o
2015-09-24  8:13                     ` Artem Bityutskiy
2015-09-23 19:03           ` Tejun Heo
2015-09-23 18:09       ` Tejun Heo
2015-09-23 18:51         ` Tejun Heo
2015-09-23 21:07           ` [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies Tejun Heo
2015-09-24  8:09             ` Artem Bityutskiy
2015-09-24  8:40               ` Dexuan Cui
2015-09-24 20:47                 ` Tejun Heo [this message]
2015-09-28 21:39                   ` Tejun Heo
2015-09-24 20:45               ` Tejun Heo
2015-09-25  6:49                 ` Artem Bityutskiy
2015-09-25 10:50                   ` Artem Bityutskiy
2015-09-25 15:49                     ` Tejun Heo
2015-09-26  8:06                       ` Artem Bityutskiy
2015-09-26 22:14                         ` Tejun Heo
2015-09-29 11:37                           ` Artem Bityutskiy
2015-09-29 14:26                             ` Tejun Heo
2015-09-24 16:17             ` Jens Axboe
2015-09-24 20:48             ` Tejun Heo
2015-07-12 18:05 ` [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
2015-07-16 19:40   ` Tejun Heo
2015-07-16 23:21     ` Dave Chinner
2015-07-16 23:37       ` Tejun Heo
2015-07-17  1:37   ` Theodore Ts'o
2015-07-17 15:20     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150924204736.GG25415@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=decui@microsoft.com \
    --cc=dedekind1@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome