From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757126AbbIYTh1 (ORCPT ); Fri, 25 Sep 2015 15:37:27 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33158 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932891AbbIYTh0 (ORCPT ); Fri, 25 Sep 2015 15:37:26 -0400 Date: Fri, 25 Sep 2015 12:37:25 -0700 (PDT) Message-Id: <20150925.123725.9649310331204777.davem@davemloft.net> To: sergei.shtylyov@cogentembedded.com Cc: sudipm.mukherjee@gmail.com, egtvedt@samfundet.no, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected From: David Miller In-Reply-To: <56058C88.3070907@cogentembedded.com> References: <1443089813-10967-1-git-send-email-sudipm.mukherjee@gmail.com> <56058C88.3070907@cogentembedded.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 25 Sep 2015 12:37:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergei Shtylyov Date: Fri, 25 Sep 2015 21:03:52 +0300 > Hello. > > On 9/24/2015 1:16 PM, Sudip Mukherjee wrote: > >> The builds of allmodconfig of avr32 is failing with: >> >> drivers/net/ethernet/via/via-rhine.c:1098:2: error: implicit >> declaration >> of function 'pci_iomap' [-Werror=implicit-function-declaration] >> drivers/net/ethernet/via/via-rhine.c:1119:2: error: implicit >> declaration >> of function 'pci_iounmap' [-Werror=implicit-function-declaration] >> >> The generic empty pci_iomap and pci_iounmap is used only if CONFIG_PCI >> is not defined and CONFIG_GENERIC_PCI_IOMAP is defined. >> >> Add GENERIC_PCI_IOMAP in the dependency list for VIA_RHINE as we are >> getting build failure when CONFIG_PCI and CONFIG_GENERIC_PCI_IOMAP >> both >> are not defined. >> >> Signed-off-by: Sudip Mukherjee ... >> @@ -17,7 +17,7 @@ if NET_VENDOR_VIA >> >> config VIA_RHINE >> tristate "VIA Rhine support" >> - depends on (PCI || OF_IRQ) >> + depends on (PCI || (OF_IRQ && GENERIC_PCI_IOMAP)) > > Could you remove outer braces, while at it? I took care of this while applying this patch, thanks everyone.