From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750846AbbIZEnA (ORCPT ); Sat, 26 Sep 2015 00:43:00 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35424 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbbIZEm6 (ORCPT ); Sat, 26 Sep 2015 00:42:58 -0400 Date: Fri, 25 Sep 2015 21:42:56 -0700 (PDT) Message-Id: <20150925.214256.1901015223799070196.davem@davemloft.net> To: huangdaode@hisilicon.com Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, catalin.marinas@arm.com, will.deacon@arm.com, liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com, paul.gortmaker@windriver.com, dingtianhong@huawei.com, zhangfei.gao@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com, kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com, lisheng011@huawei.com Subject: Re: [PATCH net-next v3] net: Fix Hisilicon Network Subsystem Support Compilation From: David Miller In-Reply-To: <1443169790-54861-1-git-send-email-huangdaode@hisilicon.com> References: <1443169790-54861-1-git-send-email-huangdaode@hisilicon.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 25 Sep 2015 21:42:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: huangdaode Date: Fri, 25 Sep 2015 16:29:50 +0800 > @@ -191,9 +191,12 @@ static void hns_rcb_ring_init(struct ring_pair_cb *ring_pair, int ring_type) > if (ring_type == RX_RING) { > dsaf_write_dev(q, RCB_RING_RX_RING_BASEADDR_L_REG, > (u32)dma); > +#ifdef CONFIG_64BIT > dsaf_write_dev(q, RCB_RING_RX_RING_BASEADDR_H_REG, > (u32)(dma >> 32)); > - > +#else > + dsaf_write_dev(q, RCB_RING_RX_RING_BASEADDR_H_REG, 0); > +#endif > dsaf_write_dev(q, RCB_RING_RX_RING_BD_LEN_REG, > bd_size_type); > dsaf_write_dev(q, RCB_RING_RX_RING_BD_NUM_REG, CONFIG_64BIT doesn't tell you if _DMA_ addresses are 64-bit or not. Furthermore there is a portable way to shift a 32-bit value down 32-bits whilst avoiding warnings. (x >> 31) >> 1 So you should definitely use that instead of the CONFIG_64BIT test.