From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525AbbIYFE7 (ORCPT ); Fri, 25 Sep 2015 01:04:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52170 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbbIYFE6 (ORCPT ); Fri, 25 Sep 2015 01:04:58 -0400 Date: Fri, 25 Sep 2015 13:04:44 +0800 From: Dave Young To: Minfei Huang Cc: ebiederm@xmission.com, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] kexec: Use file name as the output message prefix Message-ID: <20150925050444.GA11707@dhcp-129-149.nay.redhat.com> References: <1443074860-18989-1-git-send-email-mnfhuang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443074860-18989-1-git-send-email-mnfhuang@gmail.com> User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/24/15 at 02:07pm, Minfei Huang wrote: > kexec output message misses the prefix "kexec", when Dave Young split > the kexec code. Now, we use file name as the output message prefix. > > Currectly, the format of output message: > [ 140.290795] SYSC_kexec_load: hello, world > [ 140.291534] kexec: sanity_check_segment_list: hello, world > > Ideally, the format of output message: > [ 30.791503] kexec: SYSC_kexec_load, Hello, world > [ 79.182752] kexec_core: sanity_check_segment_list, Hello, world > > Remove the custom prefix "kexec" in output message. > > Signed-off-by: Minfei Huang > --- > v2: Use KBUILD_MODNAME as prefix, instead of custom string "kexec" > --- > kernel/kexec.c | 2 ++ > kernel/kexec_core.c | 4 ++-- > kernel/kexec_file.c | 2 ++ > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 4c5edc3..df772fc 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -18,6 +18,8 @@ > > #include "kexec_internal.h" > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + Move the micro to the top of the c file is better, ditto for other two files. Otherwise: Acked-by: Dave Young > static int copy_user_segment_list(struct kimage *image, > unsigned long nr_segments, > struct kexec_segment __user *segments) > diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c > index 201b453..dd21c78 100644 > --- a/kernel/kexec_core.c > +++ b/kernel/kexec_core.c > @@ -6,7 +6,7 @@ > * Version 2. See the file COPYING for more details. > */ > > -#define pr_fmt(fmt) "kexec: " fmt > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include > #include > @@ -1027,7 +1027,7 @@ static int __init crash_notes_memory_init(void) > > crash_notes = __alloc_percpu(size, align); > if (!crash_notes) { > - pr_warn("Kexec: Memory allocation for saving cpu register states failed\n"); > + pr_warn("Memory allocation for saving cpu register states failed\n"); > return -ENOMEM; > } > return 0; > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > index 6a9a3f2..66a5dc8 100644 > --- a/kernel/kexec_file.c > +++ b/kernel/kexec_file.c > @@ -22,6 +22,8 @@ > #include > #include "kexec_internal.h" > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > /* > * Declare these symbols weak so that if architecture provides a purgatory, > * these will be overridden. > -- > 1.9.1 > Thanks Dave