From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755118AbbIYGAh (ORCPT ); Fri, 25 Sep 2015 02:00:37 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36452 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbbIYGAg (ORCPT ); Fri, 25 Sep 2015 02:00:36 -0400 Date: Fri, 25 Sep 2015 14:00:32 +0800 From: Minfei Huang To: Dave Young Cc: ebiederm@xmission.com, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] kexec: Use file name as the output message prefix Message-ID: <20150925060032.GA24191@mhuang-ThinkPad-T440s> References: <1443074860-18989-1-git-send-email-mnfhuang@gmail.com> <20150925050444.GA11707@dhcp-129-149.nay.redhat.com> <20150925052448.GB11707@dhcp-129-149.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150925052448.GB11707@dhcp-129-149.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/25/15 at 01:24pm, Dave Young wrote: > On 09/25/15 at 01:04pm, Dave Young wrote: > > On 09/24/15 at 02:07pm, Minfei Huang wrote: > > > kexec output message misses the prefix "kexec", when Dave Young split > > > the kexec code. Now, we use file name as the output message prefix. > > > > > > Currectly, the format of output message: > > s/Currectly/Currently > > > > [ 140.290795] SYSC_kexec_load: hello, world > > > [ 140.291534] kexec: sanity_check_segment_list: hello, world > > > > > > Ideally, the format of output message: > > > [ 30.791503] kexec: SYSC_kexec_load, Hello, world > > > [ 79.182752] kexec_core: sanity_check_segment_list, Hello, world > > > > > > Remove the custom prefix "kexec" in output message. > > > > > > Signed-off-by: Minfei Huang > > > --- > > > v2: Use KBUILD_MODNAME as prefix, instead of custom string "kexec" > > > --- > > > kernel/kexec.c | 2 ++ > > > kernel/kexec_core.c | 4 ++-- > > > kernel/kexec_file.c | 2 ++ > > > 3 files changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/kernel/kexec.c b/kernel/kexec.c > > > index 4c5edc3..df772fc 100644 > > > --- a/kernel/kexec.c > > > +++ b/kernel/kexec.c > > > @@ -18,6 +18,8 @@ > > > > > > #include "kexec_internal.h" > > > > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > > + > > > > Move the micro to the top of the c file is better, ditto for other two files. > > s/micro/macro > Thanks, Dave. I will post next version to correct them. Thanks Minfei > > > > Otherwise: > > Acked-by: Dave Young > >