From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753614AbbIYL3w (ORCPT ); Fri, 25 Sep 2015 07:29:52 -0400 Received: from elvis.franken.de ([193.175.24.41]:49545 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbbIYL3u (ORCPT ); Fri, 25 Sep 2015 07:29:50 -0400 X-Greylist: delayed 2617 seconds by postgrey-1.27 at vger.kernel.org; Fri, 25 Sep 2015 07:29:50 EDT Date: Fri, 25 Sep 2015 12:45:53 +0200 From: Tom Bogendoerfer To: Geert Uytterhoeven Cc: Alexander Kuleshov , Sam Creasey , linux-m68k , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] m68k/sun3: Fix virtual addresses of clock and interrupt register Message-ID: <20150925104553.GA22917@alpha.franken.de> References: <1442223611-30175-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2015 at 09:21:34AM +0200, Geert Uytterhoeven wrote: > On Mon, Sep 14, 2015 at 11:40 AM, Alexander Kuleshov > wrote: > > The MMU base is 32 bits size - 0xfe000000, seems that we missed > > one zero in the definition of the clock and interrupt register > > addresses. > > Thanks for your patch! > > Have you tested this? > > This means enabling/disabling interrupts never worked on Sun 3, which > I find a bit difficult to believe. > There are other 0x0f?????? addresses in arch/m68k/sun3/mmu_emu.c. which are the correct one. Sun3 MMU doesn't even handle full 32bit addresses, it's only capable of 28 bits. That's the reason why normal m68k linux user space binaries can't work. So this patch is broken. And I'm sure the unpatched version works. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]