From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756533AbbIYNog (ORCPT ); Fri, 25 Sep 2015 09:44:36 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33249 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755924AbbIYNoe (ORCPT ); Fri, 25 Sep 2015 09:44:34 -0400 Date: Fri, 25 Sep 2015 19:14:29 +0530 From: Sudip Mukherjee To: Tomi Valkeinen Cc: Jean-Christophe Plagniol-Villard , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH] fbdev: broadsheetfb: fix memory leak Message-ID: <20150925134429.GB4799@sudip-pc> References: <1442574992-31654-1-git-send-email-sudipm.mukherjee@gmail.com> <5603CCA0.6000702@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5603CCA0.6000702@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 01:12:48PM +0300, Tomi Valkeinen wrote: > > On 18/09/15 14:16, Sudip Mukherjee wrote: > > On the error path we have missed releasing the firmware. > > > > Signed-off-by: Sudip Mukherjee > > --- > > This looks like correct fix, but where is the firmware released when > there is no error? I will send v2. Usually all the memleaks will be in the error path so I concentrate on that part. Sorry, should have looked fully. regards sudip