From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932296AbbIYOLM (ORCPT ); Fri, 25 Sep 2015 10:11:12 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:37082 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756512AbbIYOLK (ORCPT ); Fri, 25 Sep 2015 10:11:10 -0400 Date: Fri, 25 Sep 2015 16:11:08 +0200 From: Michal Hocko To: "David S. Miller" Cc: Mel Gorman , Eric Dumazet , linux-kernel@vger.kernel.org Subject: Re: [PATCH] net, skbuff: Get rid of unused skb_propagate_pfmemalloc Message-ID: <20150925141108.GL16497@dhcp22.suse.cz> References: <1440665197-23079-1-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440665197-23079-1-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 27-08-15 10:46:37, mhocko@kernel.org wrote: > From: Michal Hocko > > It seems that skb_propagate_pfmemalloc has never had a user since it was > introduced by 0614002bb5f7 ("netvm: propagate page->pfmemalloc from > skb_alloc_page to skb"). Remove it. > > Signed-off-by: Michal Hocko > --- > Hi, > this has been noticed while working on 2f064f3485cd ("mm: make page > pfmemalloc check more robust"). Has this just fallen through cracks or it is not interesting? > > include/linux/skbuff.h | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index 9b88536487e6..9fcf69daa26c 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -2252,18 +2252,6 @@ static inline struct page *dev_alloc_page(void) > } > > /** > - * skb_propagate_pfmemalloc - Propagate pfmemalloc if skb is allocated after RX page > - * @page: The page that was allocated from skb_alloc_page > - * @skb: The skb that may need pfmemalloc set > - */ > -static inline void skb_propagate_pfmemalloc(struct page *page, > - struct sk_buff *skb) > -{ > - if (page_is_pfmemalloc(page)) > - skb->pfmemalloc = true; > -} > - > -/** > * skb_frag_page - retrieve the page referred to by a paged fragment > * @frag: the paged fragment > * > -- > 2.5.0 > -- Michal Hocko SUSE Labs