From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755547AbbI0LEK (ORCPT <rfc822;w@1wt.eu>);
	Sun, 27 Sep 2015 07:04:10 -0400
Received: from mail.skyhub.de ([78.46.96.112]:52648 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755121AbbI0LEJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 27 Sep 2015 07:04:09 -0400
Date: Sun, 27 Sep 2015 13:28:54 +0200
From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@amacapital.net>, James Forcier <csssuf@csssuf.net>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, Jan Beulich <JBeulich@suse.com>,
        X86 ML <x86@kernel.org>,
        "Juergen Gross <jgross@suse.com, Toshi Kani" <toshi.kani@hp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Luis R. Rodriguez" <mcgrof@suse.com>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/mm: Export cpu_tlbstate as non-GPL symbol
Message-ID: <20150927112853.GA8329@pd.tnic>
References: <1442947897-14487-1-git-send-email-csssuf@csssuf.net>
 <CALCETrXSyNX-jO4i_Guu_TT-86JoN0RuVGjbVTQcrCMDwuz-5g@mail.gmail.com>
 <alpine.DEB.2.11.1509222056210.5606@nanos>
 <CALCETrVJbkAZr+TzmHnubnf+kGV=+Z5fezZTswNMZzHs_yf+Gg@mail.gmail.com>
 <alpine.DEB.2.11.1509271244140.4500@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.11.1509271244140.4500@nanos>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 27, 2015 at 12:46:28PM +0200, Thomas Gleixner wrote:
> > https://github.com/kolasa/fglrx-13.152/blob/master/firegl_public.c
> 
> I stopped looking at this line:
> 
> MODULE_LICENSE("GPL\0Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");

"GPL" *and* "Proprietary"??!

How does that even work?

Oh, that depends on the kernel version:

#if LINUX_VERSION_CODE < KERNEL_VERSION(3,19,0)
MODULE_LICENSE("Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");
#else
MODULE_LICENSE("GPL\0Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");
#endif

With that '\0' string terminator in there?! WTF now?!

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.