From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756284AbbI1HKy (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 03:10:54 -0400
Received: from mx2.suse.de ([195.135.220.15]:36770 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751456AbbI1HKx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 03:10:53 -0400
Date: Mon, 28 Sep 2015 09:10:47 +0200
From: Jean Delvare <jdelvare@suse.de>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Ingo Molnar <mingo@kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Benoit Cousson <bcousson@baylibre.com>,
        Fenghua Yu <fenghua.yu@intel.com>, Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS]
 with bitmap
Message-ID: <20150928091047.4d911780@endymion.delvare>
In-Reply-To: <56082E33.1020909@redhat.com>
References: <1443271638-2568-1-git-send-email-dvlasenk@redhat.com>
	<1443271638-2568-2-git-send-email-dvlasenk@redhat.com>
	<20150927181033.119a2851@endymion.delvare>
	<56082E33.1020909@redhat.com>
Organization: SUSE Linux
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 27 Sep 2015 19:58:11 +0200, Denys Vlasenko wrote:
> On 09/27/2015 06:10 PM, Jean Delvare wrote:
> > Looks good, however I think you should #include <linux/bitmap.h> to
> > avoid build failures in the future or on certain architectures.
> 
> <linux/cpumask.h> already includes <linux/bitmap.h>
> on any arch.

Today it does. Tomorrow, who knows.

> p4-clockmod.c builds only on x86 arch, it's Pentium 4
> on demand clock modulation/speed scaling module.

That is a valid point. My comment was generic, I did not pay attention
to the specific driver.

-- 
Jean Delvare
SUSE L3 Support