From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754019AbbI1WH2 (ORCPT ); Mon, 28 Sep 2015 18:07:28 -0400 Received: from mail-bn1bbn0103.outbound.protection.outlook.com ([157.56.111.103]:26432 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751754AbbI1WH1 (ORCPT ); Mon, 28 Sep 2015 18:07:27 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Date: Mon, 28 Sep 2015 17:07:17 -0500 From: Scott Wood To: Christophe Leroy CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , , Subject: Re: [PATCH v2 01/25] powerpc/8xx: Save r3 all the time in DTLB miss handler Message-ID: <20150928220717.GA6161@home.buserror.net> References: <2d35de4435e873f23d37e3b5b5fb34c64421f136.1442939410.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2d35de4435e873f23d37e3b5b5fb34c64421f136.1442939410.git.christophe.leroy@c-s.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [2601:448:8100:f9f:50d6:efef:9d58:181b] X-ClientProxiedBy: DM2PR21CA0011.namprd21.prod.outlook.com (25.161.137.149) To BN3PR03MB1477.namprd03.prod.outlook.com (25.163.35.140) X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1477;2:S75U1KQ4NNdrjzacngSaV6KIR1+oWwLfgxdIkiE4yUWdB34MX7Yh4UexmIKMsTLxp56gK8kIDeyXh7DJKwoTtfDE746LllcYIdiVpWIU777bbklYHbw2M0+CK39wAu+8hrHvLWUOeT5uYYpHlfkpKuEOKtmSOkzG8nAOAsIC2ZA=;3:8mgfyvtbkvog8VE3sXlNEet5+dT/lK+Sc0bB89BLlwrRUIAfE5d2IY/JCYLoPU9cRlUKDZ2+QvK6XX1YnkqVRwBdzZCdaQ1qfePrucPHT8faFb7IWBExOZ5MrgDg82asmU2GzYmw51vc9hCLtwHs7A==;25:npBBkL2C75xz75eapLArD1PH2DksZZp+NJy3pUS2fMl2uoJ6vgECoBjllHm79x1an0184lCpTZXsL7WklGGMFx6F/g4o21lr+vDAnk4MMfZtdYNgEs206MgFScjc+eFLL8WVnaOOqXUoowAi/x1EyYJ/oNukC1+7VPysTtd7qGYG9pssbGpIKnMU2jntb2GacwE4VQtBLlr06deFiie/GGE5xPif/Qpk1v6Ac/ypikfliGg7STzZ3M/+aw9Iqf+GPzrfbaG69ttjMzrnCq3Nrw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1477; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1477;20:hesfGFr7UfvjYNeARjWKniE1qQJuYbY7Ow0ADSoZZ8xkQpG3TszdJBvPfY/A1i3Ff47oqEC3QCDrKgyQZnnj6w/mRYluQqW9LV+j0ptmotVqxozWh955YNp/0rxTeYpUdDbu6K/oPrIbx6i+08mM5TYoJDISzl7JlfVxII9CMSUyWqGAcLy/E0wBSg0pN4JxmKj/zOPnFOIbYj6LAqWQHJ+EGtJWzMhqOmrcqTs+XfiyGMv2AX0horOEuH7fWptjKfFW1dNwnPbFmZihfYAA/+CgWjG5Y58dy4feSpGGbbfa5qHZPC4sWtsfufZg/NKNKLEWO1FhY0T29x0nG+D8tbrttYiN49+GNix1yC8C2JZZ18FgrCF8RkrRsVdQumkG37tg3Do+7pNXdT1DiQdz5Jidf+s1B2UeFHC4hJ7yFOgeLSKz+CZk4+IKdf6Mr9zo0sgrMumCG9KNNQQ4P+Fj7/aBEiHOGqZOZ28QXOlPpfH49xyBfaZF8rHt3v2IGF4k;4:Jemjvbor6zA1GHbZDOOqbf5w4QT54gwfelWH/3h1On2AeQJ23jd31bH+PmACQohqbanKziO+yzdOln/LNDijjR38LS91x38LKTHDw74CbjwNt2tdnAzIvSv1U+XOXNhnNGO7CNHkOAno83pUMMmlc8LSV3NANWomDNM6fKJL1E3c+21INSEfqAvO3Imgticx12oxQw7C2mOZgcJ+Va8zhOJWUazqfE0ZBjW0gM3cQsAaxiVf0AqZjBvtGAPoL6blRioqHC/KfsZhF2K2x/9+ofJ8jbspDz6nB3FEAy8Dcu02bylQozX5vy+Fubya04lwABhmrI2N3zVLVl74cvU1+wdo2XZLtJiieweXCnApwAo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:BN3PR03MB1477;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1477; X-Forefront-PRVS: 0713BC207F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(199003)(24454002)(33656002)(23726002)(69596002)(62966003)(5001830100001)(77096005)(47776003)(97736004)(5001860100001)(4001350100001)(4001540100001)(64706001)(68736005)(46406003)(19580405001)(92566002)(5004730100002)(53416004)(42186005)(83506001)(81156007)(5007970100001)(110136002)(189998001)(77156002)(86362001)(5001960100002)(97756001)(50986999)(105586002)(101416001)(122386002)(46102003)(106356001)(2950100001)(87976001)(76176999)(50466002)(40100003)(54356999)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1477;H:home.buserror.net;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR03MB1477;23:IlLyqhMd2UKFY2uCvXX+EgWfim8IwsBUw/wBJYMpR?= =?us-ascii?Q?ctZMu13PKn2EO+ytLNBZtF6qrFBLgJQF9UIQv3UQxlDNygzenYy0sY9jmtfm?= =?us-ascii?Q?UpI2/Nc006E5SL05ji+AAR1Do/dBR9T9bD8HjeOM13SoMHTx4BtYex6yMu93?= =?us-ascii?Q?hyhOzBUyjb6W7rZGgc3ii8M/d0nZ9P1Vr8Bmo4VfSQGqAadoKuQoXe9Xl3+r?= =?us-ascii?Q?2FQxkvXChPuDNFdfV+jA5ojWF70lKdW2/cBsMRRfBrJzS/FEZLxxroGVEt4W?= =?us-ascii?Q?FhpKnwPtIetD7PKMUdQOWT7Qt+0P7n5LFyRJWtU8pmM9VXh5WAKwXWHc0zV9?= =?us-ascii?Q?fgqv7errEP5yMmPKmmAUwIEyRC88k7ZrpJp72de1iUeAulVJosBVTCB0sLE/?= =?us-ascii?Q?P2fvdfbG6keH4PQ+o5+oisvijJjNCyMhr1B6NmgaKhu04Q+QZoaWd5r4BtqC?= =?us-ascii?Q?0zRV5WwuCa6r6OjEsWRQ5Xv+mzyHratXn/gRlME1F/CUN2kJXqqT0sJqnTWB?= =?us-ascii?Q?vJUftn5slg9pSxaIvX3+wMgEQwwffDEB2dhZHrEAlyLvp+4ISiAFS0mx1SB5?= =?us-ascii?Q?17tmMNDGWP0jSOQfUgd2AcUVwS6u+MCcx9+dFpnW9y94m8i3BsBX+wmcREN4?= =?us-ascii?Q?Q2+6G9JaJVz30Fu2PmS1eqzIK8/qyfmZIyaUQIWHpt2Xd990pvOSTdnGoJoF?= =?us-ascii?Q?NnnqF6DMUlOeV/j+0FBK+Vfnr2/8YSPkr5vutZKeEJgjUZQ1mlCEyeFTZ3AX?= =?us-ascii?Q?JsU9r+rXQrw7owEXHzkXI6p/UP2+ZVZObBYlgtlPuiLYIr30rZuL/CKpSdhd?= =?us-ascii?Q?OFhMKA1pdud9r5jhiuvxxCHBZcoTfoiu/D+TCieyPZr/0WlikCapv29JoN7n?= =?us-ascii?Q?USRuRT1GYeBaRkFlNzOVEvFepQhoNq/QLaM9jwmsprvYKMxzGDHs1ZhSAlwa?= =?us-ascii?Q?q3DCnS3tJa1vqawOIoWfQwA+6oOw8l/gG8KpB3t2nOAsvA+7MTVoFTnTo0ps?= =?us-ascii?Q?6qrtLGxYSzr8d38wl0poSYk3h6KUoLOEtwgTQxY++YiB2i7SE7d5Is8SB4bt?= =?us-ascii?Q?xYkRDEFSo+Im3Dn0DWFSmtWRaA4ycBrjMKS/Dgb6RU/BLoS7iZFExCRKfYjm?= =?us-ascii?Q?vXJWqTE5DHQ7up1A1EGYJpkcJICQLQ0gR++ONaBaKi60uf4QJr/akJeR1bAt?= =?us-ascii?Q?gllm0Lqsxopnl6V3Tk6LNiXRkE0OPZFs/0o?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1477;5:6VpswfivTrHVJNQ4R1bbbaWsqjWM/zemSRdmnv3Tkadkbhi7EjnAN4YG1riHstgro16Y++98jkvLMmB01XoJGsdfSthuReF/uy9F41cz0pqjSZuFi8FJEFelWj1kVhsjE812OCllv0VfObvS/RjAOw==;24:Y2w7WtHTp7b1PJ6nqDyRDLmfDnKhmSaED/dJYCX+4obGOXtP5yRa3wKtnlMM21Rc57Mu+xFvnwPcIKmU1Zrm8e3Mgc+LsA290LupN8yHJ9Q=;20:aKrP10IM7Zy37TjWFJFUC6uPB1PF35P3cPFgJZwU/G6BbMgeJsLxE5Dd2OHKXyX5w5aIjlMXaefQtbKB+9Mpdg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2015 22:07:23.9193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1477 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 06:50:29PM +0200, Christophe Leroy wrote: > We are spending between 40 and 160 cycles with a mean of 65 cycles in > the TLB handling routines (measured with mftbl) so make it more > simple althought it adds one instruction. > > Signed-off-by: Christophe Leroy Does this just make it simpler or does it make it faster? What is the performance impact? Is the performance impact seen with or without CONFIG_8xx_CPU6 enabled? Without it, it looks like you're adding an mtspr/mfspr combo in order to replace one mfspr. -Scott