From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753647AbbI1XjR (ORCPT ); Mon, 28 Sep 2015 19:39:17 -0400 Received: from mail-bl2on0133.outbound.protection.outlook.com ([65.55.169.133]:38992 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753167AbbI1XjQ (ORCPT ); Mon, 28 Sep 2015 19:39:16 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Date: Mon, 28 Sep 2015 18:39:00 -0500 From: Scott Wood To: Christophe Leroy CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , , Subject: Re: [PATCH v2 05/25] powerpc/8xx: Fix vaddr for IMMR early remap Message-ID: <20150928233900.GB6161@home.buserror.net> References: <83ffd345e7a3fe00443e32b6caf900e7618453d6.1442939410.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <83ffd345e7a3fe00443e32b6caf900e7618453d6.1442939410.git.christophe.leroy@c-s.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [2601:448:8100:f9f:50d6:efef:9d58:181b] X-ClientProxiedBy: DM2PR21CA0012.namprd21.prod.outlook.com (25.161.137.150) To BY1PR03MB1482.namprd03.prod.outlook.com (25.162.210.140) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;2:Xn8LhSdR0bJ/Y43mQUUqupMD3wUY6dcexiaKWXvVuXWsk3wN+/tW+ESiLCw7mSYwRGy6wLuESr9oPMR4WjFXfuZLHwFoL7K2GNQ0dilXlviT2hO6GlyzaP2SfVxDWGGqFvGjQ+47YLQDxvkA0SXwy1WZKMSEni4YRZwZld3xaWI=;3:NHeupkun2O4YxI+AhI4vbwEqaUKYx1UV7A88dTNIoAik0naNHsoSg+2mNEV8cfr0eFxGwITrqpgaB/B3tXCZKoEu5kjvd1iUHBeg8rbv6c1yvHtephjfoo4WB9T3ZHPzYvCk7ZNqtBT2qiMOUGTNEQ==;25:jIsB+iHWx4WZA6BL4+r9Df5HYPrUl8mq66qo7p+0Y/KEeYfSdSU0+Oa9vDq4PMO/ElEkdysiBckJrRqy2r2VNAGpaNd6teVm6cw7Nny8pIY/IosvbsM0fQhW6wUE7BgEK/HLOhc7xPFmSUSCo+5mjFVjXsgw6AsPO1jwBMyFpYjoX5K5fMli3vq4NzP0URV/LOSvFPL63Pdl5IP6USYLo7xWfEeGsjxjTsTBxGEG2GyKjtdZh2h56sudH4K0vrXT+borx1Mibtpen5eS96V3hg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;20:zQCFAIYxRX2cOshj3rFa0hqBFrRMo2CW66XXBKh5w5dm3KypTv4hOntsK5fMeVtgFy3nEfTv9k4H7W7CGnI354Jx8fLS83xOuvReuOEt7FKqYp85bVnfQZbGsVOdgHwzc4W3N9k0GO31j9PJs4SVdbOYroJOfUo4BWh3zvemmTrJ5hy/I4kOHcAH8CO57cLNppFTXpcZFRrAUmYOR39s9SNzRnySeb503mRK/Td/rn2TB/cPNnloviBleo2IJwMSGq4PE8MZf25J5gzE/kl8Mm2BdKiPcK7lNtvAEh6eyYaSbUl3r1mUuLA8+neETy/G/2wcW280bn0/DuC618Dx1U5Z7AFP5m773qqnMA+i7zxe2akF35Kd2eJbfOsF6jqc6So+9HcxT7YaClz5xfrk+2QX/97BnExrzl7sq9M9DjJeLKOHJJ1fl/PB4TQpgnx8J+iWFeneyeI/2i614P9t5ByKco4RLILU3wttUjmnH1D0lFxeBhNsDTnVMgBTCFur;4:vSKIymnd28yKFo4FUUlpHkiJxPC6dl084eMEanr4bMykkTf2EyOoHCQp5SDDOugKpvHQPnZKBozheqQFUr7vtwbA8Q+J/tfLmH/S/IoGvuPFkHyvvAFfeqzSI49WocoEHrd5D1mbj3qIRjKQRZmtB3aOAn+nzI8nLns+BPmpuXwGEd3fjP3cws7wlRXS0eGnLfDmTjfxUE6VbLR/Ql/4CVkd09aX1ixf8YN9fHQ/wUhrsshE6Z8Tyfhouqw6y42fjXCq+Xgb9ZXa2pnIdNXNcXP4Ss99VyNiR4oWVqQ0GvFHhJ2n+0cSxks/Kd9C1dSJkjlThuNeR+K7n7yedrkNYjHGC4qSNmptVTOd1RPkPp8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Forefront-PRVS: 0713BC207F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(24454002)(199003)(62966003)(97756001)(42186005)(46406003)(53416004)(33656002)(101416001)(83506001)(86362001)(69596002)(47776003)(64706001)(189998001)(50986999)(5001920100001)(76176999)(87976001)(92566002)(50466002)(5001960100002)(40100003)(5001860100001)(5007970100001)(2950100001)(5004730100002)(122386002)(23726002)(54356999)(77156002)(68736005)(5001830100001)(19580405001)(81156007)(4001540100001)(4001350100001)(97736004)(105586002)(106356001)(110136002)(77096005)(46102003)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:home.buserror.net;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR03MB1482;23:idHbAkiK47y3QNzxhsk7I8q6nxnYUBydxBGDmf9Q3?= =?us-ascii?Q?TbKp70UKCV+bDoAAHfFq44J22O8yqrDHTgAITv3/Nbl+z9J7A6eUcBpQ1/AR?= =?us-ascii?Q?RFvzYvOGCUeRuM/ji3TeBts0JWM4vBigNVi2xvWqhXdi6tNvvK2lL2Mft1M+?= =?us-ascii?Q?EVD9kVMYpxaD1ydO529tCLEnwMDtmMkLkOnUnQfPBsU17zA9j/4awCUqpJ4c?= =?us-ascii?Q?nXanH85VcJjsXWMf96HS8gDgr/GTt1A8csdoNYGIca9sTzAfxHTbyQ4qjdFd?= =?us-ascii?Q?Uny5/8VYjzh9/v7l1Jsbllal44987LNA0UnP574L6l+/mpO8M2rpnO8rHqVW?= =?us-ascii?Q?iwU+JoBf2nzyRATMq4jbI5khViK0ui0u8JTQqwN5L31pb4sMUeuEgFrrTGlt?= =?us-ascii?Q?PR0OCOJWNLPWPhyQDcQfGcZEb96LbS/N+oCojE6HV/LS7jqdvxzCO0aIXtoN?= =?us-ascii?Q?F8TfInyTcSxLPi4qPK43sh3dKRzCxDVC5T55sGBSxmRqGzqCFbagDdyLRe16?= =?us-ascii?Q?7PRykC3pgi1sXJF5POA+ToD5R43bqvtrR+s83pryq9aS0+KYdR5f4XgDpIYe?= =?us-ascii?Q?a89u07+0FB1G8IDgHgEnc5NnIch/3mmArREA52N3KJ9ZX9w5ZXriKsM82m14?= =?us-ascii?Q?1ZOQ/BZI9dYsabZr87FBPTCm/ZTxh7ht7OnnsVvJJZfvpDu2DK1DqsbhKS55?= =?us-ascii?Q?a3OUVDJzM0GWKru6DXkro+MR1qY6WNA9HVNva/t34/BDLkcN3N+w9Nn4j6Ob?= =?us-ascii?Q?hiOAYKxv6knxRW/F0L1ETxIpKedZihpvb3V6QY3/P2Wam6DUp+qftomy6YWM?= =?us-ascii?Q?sNcNRT3AAwwDbzmTQr9qW7pktwdWMWcqzcAMdDTYBGoQAc9fZA2zNmj7E1DZ?= =?us-ascii?Q?0oEo+mMQUDXE5KbJQ+xtyGcatjCg3zjUsUP3o90T1ZVqeJydukqFx6Jjonom?= =?us-ascii?Q?I8MRUqxC0EIfyWICN9TFp4E+BCrJCFBI7AqGMyToRHGT99dUpLNlqF6a2yMa?= =?us-ascii?Q?6H9HB3p4nLONjDpFdVVe8eq9I3yEUS4Px9lH+t5hFMBJwkRQDj33BULAOKfl?= =?us-ascii?Q?jhneJPfcI0zamyALcoIhOBjAFhxcztTCZiLHUjzi8ynRwf+W8z9on9sj6E62?= =?us-ascii?Q?kRuY5kvjklTgQywLTgXG4ZxyhEM4oYhdlANX0v72FYWpwOXpEa0kCeR4D1+U?= =?us-ascii?Q?k+YiMw+tuk6oz0zRX+IHzr4Z3ONR0SUGKDL5oMxqijhN3eCnqvzhMfgbA6Hg?= =?us-ascii?Q?pZ53Rb3ZSpl7btvl84=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;5:8E3zH6AB68y3AyrZ672OyxaqVYzkAV0ta0IvoJ/cVItdlmZtovSwbNzB0wc2ee7QfVND1kUrwnf/g/bvTnZm9H5Gq5eQsSt5KXr/DzQY8ePvjtws1Y1OGpSe6ZP8IHz81dBRgPQ2Pypp0A0WGj/OYg==;24:WFVFH0b4sWeYAO0Bvet5b4TsBQZvltHQY78m++CY3nt3IUem7iRllnvax4G5IRV9unoo2C+emJyuYWu6CjbchyluAJK0BkhA3A18Wfkxvsc=;20:qSnM4jaeRRTJQKW2sFg1HB6fmvIaeJ59qpilveAqyFShr5p+RkdAnuMOyRo6xJE4c8wIF/ohxoLoFIhmuJagew== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2015 23:39:07.3267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 06:50:38PM +0200, Christophe Leroy wrote: > Memory: 124428K/131072K available (3748K kernel code, 188K rwdata, > 648K rodata, 508K init, 290K bss, 6644K reserved) > Kernel virtual memory layout: > * 0xfffdf000..0xfffff000 : fixmap > * 0xfde00000..0xfe000000 : consistent mem > * 0xfddf6000..0xfde00000 : early ioremap > * 0xc9000000..0xfddf6000 : vmalloc & ioremap > SLUB: HWalign=16, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 > > Mapping IMMR 1:1 is just wrong because it may overlap with another > area. On most mpc8xx boards it is OK because IMMR is set to > 0xff000000 but for instance on EP88xC board, IMMR is at 0xfa200000 > which overlaps with VM ioremap area > > This patch fixes the virtual address for remapping IMMR to 0xff000000, > regardless of the value of IMMR. > > The size of IMMR area is 256kbytes (CPM at offset 0, security engine > at offset 128) so 512kbytes is enough and allows to handle the EP88xC > case (which is not 8Mbytes but only 2Mbytes aligned) the same way. > > Signed-off-by: Christophe Leroy Instead of hardcoding 0xff000000, can you use asm/fixmap.h to allocate a virtual address at compile time? -Scott