From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753857AbbI1Xla (ORCPT ); Mon, 28 Sep 2015 19:41:30 -0400 Received: from mail-by2on0118.outbound.protection.outlook.com ([207.46.100.118]:39568 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752984AbbI1Xl2 (ORCPT ); Mon, 28 Sep 2015 19:41:28 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Date: Mon, 28 Sep 2015 18:41:16 -0500 From: Scott Wood To: Christophe Leroy CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , , Subject: Re: [PATCH v2 06/25] powerpc32: iounmap() cannot vunmap() area mapped by TLBCAMs either Message-ID: <20150928234116.GC6161@home.buserror.net> References: <2b94a5b931daa6aa2f32ddad88175d932da4d573.1442939410.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2b94a5b931daa6aa2f32ddad88175d932da4d573.1442939410.git.christophe.leroy@c-s.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [2601:448:8100:f9f:50d6:efef:9d58:181b] X-ClientProxiedBy: BN4PR15CA0030.namprd15.prod.outlook.com (25.164.54.168) To BY1PR03MB1484.namprd03.prod.outlook.com (25.162.210.142) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;2:qqqeNWoIvpzNldIUgyeVTLzyOXw+WTGsVDdrLSGvR52koHGpRFJ1ctBZ9g0oUu0mIzWHGvh7atClqcOP8TBO5eOZrd759oZ0jTQWr8repzdjFFpwNIhxTQpPIJ1xNlu0zZLxW9vNwrLWUac6dmUZyvk2gU9KXc7xgG7/3t66f6M=;3:FFB1LgewAoSpqcayyWjNGMM1+zCyHke6G5EoAC+UZYDqKwtTFGj+5/XpVF1DSo7Xa7ooDhaOgrM+6U+IcbSTXQJ7eTxfh0mJRa68c2hlRgunU0RoxRR0rXcjAWfCYfr0xLK0affX2D3VzSgEcuxmnA==;25:7BpgwkdUIzD1WxbGey9J1groi/lZmR8DthX/ZeKVbf6Z+4oa6o8GoHdX/WCM2/s4BgYm1cmS76rzA4KKoy8cbeU4PS5IShLL3X0pHFrh1SxRKSDouRGUSZqM/ZANZttm0JI9arSg9BDt/TpkrDJLVRObRA5a4dzZN/v0tKcoGHc395//Hk5xb/ru+IUlducjK+6GPe8es1ML0DTp9ak3+6pSPK3PmsoBzBUzF3eBpXXJaLZWsK7f/T2RvgbVJ0DEAOoExa8rCdXOKJwPkXn+vA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1484; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;20:KENWduGBsx0xvi/qIoPxxnRVIGViayfbTYVHHXsFrBE/x8PFkvu8yZ3xPwij3OZY3Y8+06EnCr1JUliKCOcwCA5svS83fOugGQjsmHr0O9AgRWZAXjM3q6jvXEM/ooGd0wQ89wyu50sV4PZB21UvnGsQTLLznButNwMu0z2GGnDvhvDCo5CVfK3us9yADdPSajdwyz+TSTgm8q5G/O5nGOS41UqBXGdEe4gB1R1swVMQSUagIyW3zPw7RnfFq9DtDH9UJXvyyPMxpWdyGsHJIM67yU7j2pPV9jMcWRogdDCxogVpm4blx2z64C2EZFokC133NlLgQQikz5aSqWuWPrV+LfPCcfhKRNUuCIOS9daL0xZjQDZotUS8yf/la0DUKOcEoLyy4bfoVJcbxzCT+yNaUdWoAFV4c0pdX4S1VyEGo8gi6RUZWN3fGwwUecvrGKKhyhlPoFROH927WuBOTV43mutQkwgHXSjdeqraKgHidtA6AnzKvwn9PVrwb47s;4:pWPUR6SUAVbUrm8WIu3uR4JQEsIGOQoyY2AYLMwxJJ4JYdXi+CSYZ31ZBJ1c1aJ+OGsZgr7/ldtVQvnTZlockuKsCw1HQ6TvdEGq9cbw7Jl+AgZEDmsX5XJuWsxMiu+G6uwZSmnIK5EQCP/2sct+8KPdDcbfcE+D7hU3X8SuUno9eeEzZ5oUkMjWhlV1z8PQ9vKSkbSsFfpA8G2XaudNYM2qahpfUGuJSYCdGi79WK+jRykBafTcf3ZjlyeE+ElW7loh4/R2CiUwc+dXWalaidRtAFP8PRdPJeqjMab6Vd/FPny3wB5sOzGHHQkWPPtuwUlpYZsuXZcvIeCwuPLh7xu30HVEUHJ3fJP2Q1mXwoQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:BY1PR03MB1484;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1484; X-Forefront-PRVS: 0713BC207F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(24454002)(97756001)(33656002)(4001350100001)(4001540100001)(81156007)(86362001)(105586002)(5001860100001)(46406003)(69596002)(5001920100001)(77096005)(2950100001)(5007970100001)(189998001)(97736004)(77156002)(62966003)(106356001)(5004730100002)(68736005)(42186005)(50986999)(110136002)(47776003)(5001960100002)(53416004)(76176999)(50466002)(5001830100001)(101416001)(64706001)(54356999)(19580405001)(23726002)(87976001)(92566002)(40100003)(46102003)(122386002)(83506001)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1484;H:home.buserror.net;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR03MB1484;23:jvo32yAA6xteJNmArzBllcGY6NkwVmA6NBFJ3g5+X?= =?us-ascii?Q?vdhnbHaeAuL++Roh6Oc8+MX40XpPEKg8M2iXWRymHOIf/p1zfHsYUHw7Sgm3?= =?us-ascii?Q?cnZX3geXNXJb5uGQcXvJSnsRjW3vVApV7eV4fZu7yDoYsdWChs0IrXFP/MNf?= =?us-ascii?Q?OtI8Spb7WNpxLxvduSRff11xrqLQpz1/Cn9tqmdO7seeI1fRVQGHHQt2GegG?= =?us-ascii?Q?kq9GtoafxHeUeHnlyjMDRy9mmk2ADPFx6t36s9kZ3qx1PISic/n9KjXZDglN?= =?us-ascii?Q?SPSO+AkUV6gs6OUzHKbBlTvGi8OvR+t4gM3jORpiPERganP/07JHSzW9K1vc?= =?us-ascii?Q?UymVFtaoqBfItvySVj0pAvN/zSkLJ7EF/dBuILHtSNwYQ81kBepjZk1YNT0i?= =?us-ascii?Q?LlNzZ2Io4jM25vafvKv6+An6BCl0GqV7uCYLU9gXowDSjpSimhIqgv2y4PB7?= =?us-ascii?Q?cuGEvNqE/Zuo9mvflWvbN93X9sZIioclf2m/NZmVyFvdkq4Vq+MTb0tgMJUa?= =?us-ascii?Q?Ybtn1zlALw0hO0VKJXE/hD9p//C5vkOIhM6v3Mz2RuPnJtRWFlCNnXUHaVUA?= =?us-ascii?Q?PSP38a0yR8mFCTZ0QDTZG75ZuYR0l3yYsMPyZWLFZhobaP2JAi0HHKmQr+v8?= =?us-ascii?Q?uKMVmNdV6jHofsVwD/d2VRK9B/TnZcs3jgsWdAZdF1GCvXk0XY2pDkHWx8Kr?= =?us-ascii?Q?t8++V5C7g+ioAMqMWQdrJgQL2dmlVIs99QCyLfkZNjAq6GCNCULdo0dveHdF?= =?us-ascii?Q?VvSK+95p1luyPz1e4NAC38qnxYnvMwNRTM9hetad10vEkMWzi8kYXeoNKz9l?= =?us-ascii?Q?L+J0sQiPi+ej7uzK2dt8LJrSQRaO/5t/IpQWXM5zLtkOaxtX8XiXgq/KFPF8?= =?us-ascii?Q?Cpsf+SGuLI3YPrSWQih+30DhaeMPnrplo3jH76maAx+VYggfhzFZjPkdRmeG?= =?us-ascii?Q?5Z6L4MJ7/ZZKCb4Pgrdt3J8SZNRvvaoFDAysQWxIQAUMZ/OlZQbbL8fzfLJF?= =?us-ascii?Q?4WD2yGJGxZxFTdlY1/cF/ryOOsBNcwsseHZeWpH1qjEv7OphfrsSeiZ8E2BN?= =?us-ascii?Q?eiIYFTCKAa6jhYS73zfaUNBukvBA2Vcy6bK0VVZTPDBtx5xwEo2MqEB6GJ2E?= =?us-ascii?Q?dzofw4ZADfCOu+2AHXxavbfcOZr0xiScFfNhCFXWr+EC+IwK9vIqDoIk+WYK?= =?us-ascii?Q?cFWdt16voC4mAgxpSiquGUCl1rcevZE4MctXG1ywD/SSsyvAqHq3MLGd+jWj?= =?us-ascii?Q?IW96eDk7pwnYu4/feE=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;5:+DoSSqp9U5wPtRQD1Bfzmevldmt/BBWX3EXKNOgBiFlLfrsVDEUYZt1ySdb3W7V1MrF2o+ahkqNh7kj+L7fZJN+9A8a91tWNE0fkzIvyy7xI14U0YXeqTDUC9tTR+sVWooiMnWivKRS7fxtc/ghdkA==;24:Tmgk0TgYVksJme5FMom59NTMMRgrWSeNpDCmugQPZe33we1jYQ07metbLBK2J2kcdYxS4/m42s3/TTKEhy8MZ2joTMAAsLkf300xgdwC8nk=;20:1x+AkR1Shdp/VqeJ7v5OvQKy0+snRzKBXW0BR+2RiR0U7Mx9rRAFKzEmXVWm0Kgv7ZnLu5ULDtE93v1pgQjcFQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2015 23:41:24.6000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1484 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 06:50:40PM +0200, Christophe Leroy wrote: > iounmap() cannot vunmap() area mapped by TLBCAMs either > > Signed-off-by: Christophe Leroy > --- > No change in v2 > > arch/powerpc/mm/pgtable_32.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c > index 7692d1b..03a073a 100644 > --- a/arch/powerpc/mm/pgtable_32.c > +++ b/arch/powerpc/mm/pgtable_32.c > @@ -278,7 +278,9 @@ void iounmap(volatile void __iomem *addr) > * If mapped by BATs then there is nothing to do. > * Calling vfree() generates a benign warning. > */ > - if (v_mapped_by_bats((unsigned long)addr)) return; > + if (v_mapped_by_bats((unsigned long)addr) || > + v_mapped_by_tlbcam((unsigned long)addr)) > + return; This is pretty pointless given that the next patch replaces both with v_mapped_by_other(). -Scott