From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752329AbbI3EfT (ORCPT ); Wed, 30 Sep 2015 00:35:19 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33341 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbbI3EfR (ORCPT ); Wed, 30 Sep 2015 00:35:17 -0400 Date: Tue, 29 Sep 2015 21:35:16 -0700 (PDT) Message-Id: <20150929.213516.1675265710298613345.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch Subject: Re: [PATCH net-next] net: dsa: fix preparation of a port STP update From: David Miller In-Reply-To: <1443544716-9130-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1443544716-9130-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Sep 2015 21:35:16 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Tue, 29 Sep 2015 12:38:36 -0400 > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > driver may return -EOPNOTSUPP from the commit phase of a STP state, > which triggers a WARN() from switchdev. > > This happened on a 6185 switch which does not support hardware bridging. > > Reported-by: Andrew Lunn > Signed-off-by: Vivien Didelot Applied.