From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932151AbbI2BX6 (ORCPT ); Mon, 28 Sep 2015 21:23:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49757 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069AbbI2BX4 (ORCPT ); Mon, 28 Sep 2015 21:23:56 -0400 Date: Tue, 29 Sep 2015 02:44:02 +0200 From: Greg KH To: Chandra S Gorentla Cc: dan.carpenter@oracle.com, johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com Subject: Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists Message-ID: <20150929004402.GB7811@kroah.com> References: <1443464037-3591-1-git-send-email-csgorentla@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443464037-3591-1-git-send-email-csgorentla@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > - The message queue is replaced with standard Linux linked list > - kmem_cache is used for list members Why? > - A check for return value of receive method is added > - GFP_ATOMIC is changed to GFP_KERNEL Why? Are you sure that is safe? > - A few other related minor changes Be specific please. thanks, greg k-h