From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbbI2BqA (ORCPT ); Mon, 28 Sep 2015 21:46:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53196 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755188AbbI2Bp5 (ORCPT ); Mon, 28 Sep 2015 21:45:57 -0400 Date: Tue, 29 Sep 2015 03:23:15 +0200 From: Greg KH To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, amaury.denoyelle@gmail.com, abbotti@mev.co.uk Subject: Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code Message-ID: <20150929012315.GB1252@kroah.com> References: <1443473685-3689-1-git-send-email-luisbg@osg.samsung.com> <1443474642-9965-1-git-send-email-luisbg@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443474642-9965-1-git-send-email-luisbg@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2015 at 10:10:42PM +0100, Luis de Bethencourt wrote: > Remove the disabled code, for now, with #if 0. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > The code after the return is dead code. There is a comment saying it is > disabled for now, it would be good if the code is removed with #if 0 as > well. The compiler doesn't add it anyway, so this is the same as what you just did, so I don't think it's needed. thanks, greg k-h