From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755437AbbI2Gwp (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 02:52:45 -0400
Received: from verein.lst.de ([213.95.11.211]:57476 "EHLO newverein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755304AbbI2Gwg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 02:52:36 -0400
Date: Tue, 29 Sep 2015 08:52:35 +0200
From: Christoph Hellwig <hch@lst.de>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Ming Lei <tom.leiming@gmail.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map
Message-ID: <20150929065235.GB14911@lst.de>
References: <1443287365-4244-1-git-send-email-akinobu.mita@gmail.com> <1443287365-4244-4-git-send-email-akinobu.mita@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443287365-4244-4-git-send-email-akinobu.mita@gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Can you also add a patch that renames blk_mq_free_queue to
blk_mq_cleaup_queue and adds a comment that we should not free any memory
here?  We had  way too many bugs of this kinds unfortunately.