From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934624AbbI2KrV (ORCPT ); Tue, 29 Sep 2015 06:47:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39890 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934041AbbI2KrO (ORCPT ); Tue, 29 Sep 2015 06:47:14 -0400 Date: Tue, 29 Sep 2015 12:47:11 +0200 From: Jiri Olsa To: "Naveen N. Rao" Cc: LKML , Arnaldo Carvalho de Melo , "mingo@redhat.com" , Stephane Eranian , Sukadev Bhattiprolu , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS Message-ID: <20150929104711.GE27383@krava.redhat.com> References: <1443096718-11926-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com> <20150924125703.GA11857@krava.redhat.com> <20150924164554.GA11493@naverao1-tp.in.ibm.com> <20150929053617.GA1060@naverao1-tp.in.ibm.com> <20150929065335.GE18363@krava.redhat.com> <20150929080010.GB1060@naverao1-tp.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150929080010.GB1060@naverao1-tp.in.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 01:30:10PM +0530, Naveen N. Rao wrote: SNIP > > > Suka has also posted a fix for this with a different approach [1]. Can > > > you please ack/pull one of these versions? Building perf is broken on > > > v4.3-rc due to this. > > > > I did not get any answer for additional comments I made to the patch > > (couldnt get marc.info working, sending the patch again) > > Hi Jiri, > I concur with the changes you proposed to my patch here (getting rid of > the weak variant): > http://article.gmane.org/gmane.linux.kernel/2046108 > > I am aware of the other approach you posted (and the one attached > below). When I said "please ack/pull one of these versions", I meant one > of: your version, Suka's and mine. I was hoping somebody could test it on ppc ;-) I think the last version (in my last email) that keeps the weak variable is correct, let's wait for Arnaldo to sort this out > > > > > > > > > [1] http://article.gmane.org/gmane.linux.kernel/2046370 > > > > I dont have this last version, which seems to have other changes > > and patch in above link looks mangled, could you please repost it? > > Can you please check the raw version: > http://article.gmane.org/gmane.linux.kernel/2046370/raw we have __maybe_unused definition in tools/include/linux/compiler.h why to redeclare it? jirka