From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935238AbbI2PlQ (ORCPT ); Tue, 29 Sep 2015 11:41:16 -0400 Received: from smtprelay0097.hostedemail.com ([216.40.44.97]:46495 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933684AbbI2PlH (ORCPT ); Tue, 29 Sep 2015 11:41:07 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3868:3870:3871:3872:3873:3874:5007:6261:7875:8660:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12294:12296:12438:12517:12519:12740:13069:13148:13230:13311:13357:14096:14097:21080:21220,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: chalk80_26687c49d0f03 X-Filterd-Recvd-Size: 2149 Date: Tue, 29 Sep 2015 11:41:02 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com, tglx@linutronix.de Subject: Re: [RFC][PATCH 07/11] sched: Stop setting PREEMPT_ACTIVE Message-ID: <20150929114102.6c5f2402@gandalf.local.home> In-Reply-To: <20150929093520.316380243@infradead.org> References: <20150929092825.540553633@infradead.org> <20150929093520.316380243@infradead.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015 11:28:32 +0200 Peter Zijlstra wrote: > Now that nothing tests for PREEMPT_ACTIVE anymore, stop setting it. > > Signed-off-by: Peter Zijlstra (Intel) > @@ -3243,13 +3243,7 @@ asmlinkage __visible void __sched notrac > return; > > do { > - /* > - * Use raw __prempt_count() ops that don't call function. > - * We can't call functions before disabling preemption which > - * disarm preemption tracing recursions. > - */ > - __preempt_count_add(PREEMPT_ACTIVE + PREEMPT_DISABLE_OFFSET); > - barrier(); > + preempt_disable_notrace(); > /* > * Needs preempt disabled in case user_exit() is traced > * and the tracer calls preempt_enable_notrace() causing > @@ -3259,8 +3253,7 @@ asmlinkage __visible void __sched notrac > __schedule(true); > exception_exit(prev_ctx); > > - barrier(); > - __preempt_count_sub(PREEMPT_ACTIVE + PREEMPT_DISABLE_OFFSET); > + preempt_enable_no_resched_notrace(); Nice, you used the notrace variants for this function. Reviewed-by: Steven Rostedt -- Steve > } while (need_resched()); > }