From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933745AbbI2QaQ (ORCPT ); Tue, 29 Sep 2015 12:30:16 -0400 Received: from smtprelay0059.hostedemail.com ([216.40.44.59]:37726 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932194AbbI2QaJ (ORCPT ); Tue, 29 Sep 2015 12:30:09 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3351:3622:3865:3867:3874:5007:6119:6261:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12114:12517:12519:12740:13069:13137:13138:13150:13230:13231:13311:13357:14039:21067:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: legs29_1e2c4e1f8b309 X-Filterd-Recvd-Size: 1663 Date: Tue, 29 Sep 2015 12:30:06 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com, tglx@linutronix.de Subject: Re: [RFC][PATCH 06/11] sched: Fix trace_sched_switch() Message-ID: <20150929123006.0001367e@gandalf.local.home> In-Reply-To: <20150929154828.GS3816@twins.programming.kicks-ass.net> References: <20150929092825.540553633@infradead.org> <20150929093520.240883073@infradead.org> <20150929113812.0bc594d0@gandalf.local.home> <20150929154828.GS3816@twins.programming.kicks-ass.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015 17:48:28 +0200 Peter Zijlstra wrote: > /SHOULD/ being the operative word. Experience has taught me that > changing the sched tracepoint leads to borkage. Right. But experience also tells us that those relying on offsets will get brokage if they run 32 bit userspace on a 64 bit kernel too. > > But we can sure try, see if someone notices etc.. Same with > trace_sched_wakeup(), that still prints a dummy value. Removing a field can break things that even use the parsing library. That's why we still have that. -- Steve