From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755583AbbI2Ox1 (ORCPT ); Tue, 29 Sep 2015 10:53:27 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:39342 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132AbbI2OxQ (ORCPT ); Tue, 29 Sep 2015 10:53:16 -0400 Date: Tue, 29 Sep 2015 16:47:51 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com, tglx@linutronix.de Subject: Re: [RFC][PATCH 01/11] sched: Simplify INIT_PREEMPT_COUNT Message-ID: <20150929144751.GM3816@twins.programming.kicks-ass.net> References: <20150929092825.540553633@infradead.org> <20150929093519.706413197@infradead.org> <20150929104332.69571e98@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150929104332.69571e98@gandalf.local.home> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 10:43:32AM -0400, Steven Rostedt wrote: > > [ Resend with a "Reply-all" this time! ] > > On Tue, 29 Sep 2015 11:28:26 +0200 > Peter Zijlstra wrote: > > > As per commit d86ee4809d03 ("sched: optimize cond_resched()") we need > > PREEMPT_ACTIVE to avoid cond_resched() from working before the > > scheduler is setup. > > > > However, keeping preemption disabled should do the same thing already, > > making the PREEMPT_ACTIVE part entirely redundant. > > Thus PREEMPT_ACTIVE wasn't needed at that commit either, or was it? Correct. We might have actually discussed that at that time but decided to be conservative -- but these be vague memories..